Fix deadlock in terminal view rendering.#10308
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
| } | ||
|
|
||
| /// Create a SyncEvent for other terminals to use based on | ||
| /// the state of this terminal. If this terminal view has an active input |
There was a problem hiding this comment.
was this comment just on the wrong fn lol
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR refactors is_cloud_agent_pre_first_exchange to accept a borrowed TerminalModel, moving locking responsibility to call sites that already have or can create the terminal-model guard. The changed render and shared-session paths avoid the previous nested terminal-model lock while keeping the pre-first-exchange checks scoped to the same model state.
Concerns
- No blocking correctness or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
## Description Update `is_cloud_agent_pre_first_exchange` to take in `&TerminalModel` instead of locking internally, which is super prone to deadlocks
2 participants
Description
Update
is_cloud_agent_pre_first_exchangeto take in&TerminalModelinstead of locking internally, which is super prone to deadlocks