Add custom warping verbs (spinner verbs) feature by eluzzi5 · Pull Request #10384 · warpdotdev/warp

eluzzi5 · 2026-05-07T17:32:54Z

Description

Migrates the custom warping verbs feature from the internal repo to the public repo. This feature allows users to customize the spinner verb phrases shown while the Warp agent is processing (e.g. replacing Warping with custom phrases or built-in preset packs like medieval, conspiracy, cooking, warpy).

Changes:

Added CustomWarpingVerbs feature flag (dogfood-enabled)
Added custom_warping_verbs setting in AI settings with full schema/description
Added warping verb pack definitions and normalization logic
Added spinner verb mode selector and custom editor in the AI settings page
Updated the modify-settings skill to document spinner verb handling
Updated status bar to display custom warping verbs

Linked Issue

Closes #7342

The linked issue is labeled ready-to-spec or ready-to-implement.
Where appropriate, screenshots or a short video of the implementation are included below.

Testing

I have manually tested my changes locally

Agent Mode

Warp Agent Mode - This PR was created via Warp AI Agent Mode

Co-Authored-By: Oz oz-agent@warp.dev

Adds the CustomWarpingVerbs feature flag and setting, allowing users to customize the spinner verb phrases shown while the Warp agent is processing. Includes built-in preset packs (medieval, conspiracy, cooking, warpy) and a custom freeform editor in AI settings. Co-Authored-By: Oz <oz-agent@warp.dev>

oz-for-oss · 2026-05-07T17:33:08Z

@eluzzi5

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds the custom warping/spinner verbs setting, preset packs, Settings UI controls, bundled skill guidance, and status-bar rendering changes.

Concerns

The new Settings UI code references Wrap::row() without importing Wrap, so the PR will not compile.
The custom spinner verb editor persists on every edit; clearing the field normalizes to an empty list, flips the mode back to Default, and hides the editor while the user is trying to replace the list.
app/src/settings_view/teams_page.rs contains unrelated Teams settings layout changes that should not ship in the spinner-verbs PR.

Verdict

Found: 1 critical, 1 important, 1 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-05-07T17:44:05Z

+    Border, ChildView, Clipped, ConstrainedBox, CornerRadius, CrossAxisAlignment, Dismiss,
+    Expanded, Fill, HyperlinkLens, MainAxisAlignment, MainAxisSize, MouseStateHandle, Radius,
+    Shrinkable, Text,


🚨 [CRITICAL] Wrap::row() is used below but Wrap is not imported, so this file will not compile.

Suggested change

Border, ChildView, Clipped, ConstrainedBox, CornerRadius, CrossAxisAlignment, Dismiss,

Expanded, Fill, HyperlinkLens, MainAxisAlignment, MainAxisSize, MouseStateHandle, Radius,

Shrinkable, Text,

Border, ChildView, Clipped, ConstrainedBox, CornerRadius, CrossAxisAlignment, Dismiss,

Expanded, Fill, HyperlinkLens, MainAxisAlignment, MainAxisSize, MouseStateHandle, Radius,

Shrinkable, Text, Wrap,

oz-for-oss · 2026-05-07T17:44:06Z

+                    me.spinner_verb_mode = SpinnerVerbMode::Custom;
+                    AISettings::handle(ctx).update(ctx, |settings, ctx| {
+                        settings.set_custom_warping_verbs(
+                            verbs.split(',').map(str::to_owned).collect(),


⚠️ [IMPORTANT] Saving on every edit makes an empty editor normalize to [], which triggers SpinnerVerbMode::Default and hides the Custom editor while users are clearing the field to type a new list. Defer writes until blur/submit or keep Custom mode sticky for user edits even when the normalized list is empty.

oz-for-oss · 2026-05-07T17:44:06Z

+        // 32px of breathing room above and below the divider.
+        // The 32px above comes from the invitation section's bottom padding
+        // (overridden below); `margin_bottom` provides the 32px below.
+        main_content.add_child(


💡 [SUGGESTION] These Teams settings layout changes are unrelated to spinner verbs and should be moved to a separate PR or reverted from this one.

Co-Authored-By: Oz <oz-agent@warp.dev>

peicodes · 2026-05-07T19:19:38Z

/oz-review

oz-for-oss · 2026-05-07T19:19:52Z

@peicodes

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds dogfood-gated custom warping/spinner verbs, including settings schema support, verb normalization/selection, preset packs, settings UI controls, status-bar integration, and bundled skill documentation. The diff also contains unrelated Teams settings layout changes.

Concerns

Manual testing and visual evidence are missing for user-visible settings/status UI changes; the PR body leaves both the manual-testing and screenshots/video checkboxes unchecked. Manual testing is required for changes that can be manually tested. Please include screenshots or a screen recording that show it working end to end, or justify why manual testing is not possible.
The Teams settings layout changes are unrelated to the spinner-verbs feature and should be removed from this PR or separately described and tested.

Verdict

Found: 0 critical, 2 important, 1 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-05-07T19:30:08Z

+        // The 32px above comes from the invitation section's bottom padding
+        // (overridden below); `margin_bottom` provides the 32px below.
+        main_content.add_child(
+            Container::new(Empty::new().finish())


⚠️ [IMPORTANT] These Teams settings layout changes are unrelated to the spinner-verbs feature and the PR has no description or visual evidence for them; remove these hunks or document/test them separately.

oz-for-oss · 2026-05-07T19:30:09Z

+        .finish();
+
+        let description = render_ai_setting_description(
+            "Customize the generic in-progress text Oz shows while it is working. Tool-specific status messages are unaffected.",


💡 [SUGGESTION] Keep the user-facing copy consistent with the feature scope, which also applies to the local Warp Agent spinner.

Suggested change

"Customize the generic in-progress text Oz shows while it is working. Tool-specific status messages are unaffected.",

"Customize the generic in-progress text shown while Warp Agent or Oz is working. Tool-specific status messages are unaffected.",

peicodes · 2026-05-12T15:53:27Z

I'm probably not the right person to review this PR - I haven't touched any of the related code. Let's go through Oz's automated review process until it auto-assigns a reviewer based on STAKEHOLDERS.

Which repo was this copied from? How much of it was modified?

The original issue was marked ready to spec but not ready to implement, which means we're expecting a PRODUCT.md and a TECH.md. For internal contributors, it's probably fine to have the specs alongside the code, but we do expect to see those especially if the PR is agent-generated.

We should also include screenshots and videos for visual changes in PR descriptions.

cla-bot Bot added the cla-signed label May 7, 2026

oz-for-oss Bot reviewed May 7, 2026

View reviewed changes

Fix CI: add missing Wrap import and fix formatting

8e3221e

Co-Authored-By: Oz <oz-agent@warp.dev>

eluzzi5 requested a review from peicodes May 7, 2026 19:00

oz-for-oss Bot reviewed May 7, 2026

View reviewed changes

eluzzi5 added 2 commits May 7, 2026 16:52

Merge branch 'master' into erica/spinner-verbs

0621446

Merge branch 'master' into erica/spinner-verbs

70ae4ff

peicodes removed their request for review May 12, 2026 15:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add custom warping verbs (spinner verbs) feature#10384

Add custom warping verbs (spinner verbs) feature#10384
eluzzi5 wants to merge 4 commits into
masterfrom
erica/spinner-verbs

eluzzi5 commented May 7, 2026 •

edited

Loading

Uh oh!

oz-for-oss Bot commented May 7, 2026 •

edited

Loading

Uh oh!

oz-for-oss Bot left a comment

Uh oh!

oz-for-oss Bot May 7, 2026

Uh oh!

oz-for-oss Bot May 7, 2026

Uh oh!

oz-for-oss Bot May 7, 2026

Uh oh!

peicodes commented May 7, 2026

Uh oh!

oz-for-oss Bot commented May 7, 2026 •

edited

Loading

Uh oh!

oz-for-oss Bot left a comment

Uh oh!

oz-for-oss Bot May 7, 2026

Uh oh!

oz-for-oss Bot May 7, 2026

Uh oh!

peicodes commented May 12, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	"Customize the generic in-progress text Oz shows while it is working. Tool-specific status messages are unaffected.",
	"Customize the generic in-progress text shown while Warp Agent or Oz is working. Tool-specific status messages are unaffected.",

Conversation

eluzzi5 commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked Issue

Testing

Agent Mode

Uh oh!

oz-for-oss Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot May 7, 2026

Choose a reason for hiding this comment

Uh oh!

oz-for-oss Bot May 7, 2026

Choose a reason for hiding this comment

Uh oh!

oz-for-oss Bot May 7, 2026

Choose a reason for hiding this comment

Uh oh!

peicodes commented May 7, 2026

Uh oh!

oz-for-oss Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot May 7, 2026

Choose a reason for hiding this comment

Uh oh!

oz-for-oss Bot May 7, 2026

Choose a reason for hiding this comment

Uh oh!

peicodes commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eluzzi5 commented May 7, 2026 •

edited

Loading

oz-for-oss Bot commented May 7, 2026 •

edited

Loading

oz-for-oss Bot commented May 7, 2026 •

edited

Loading

peicodes commented May 12, 2026 •

edited

Loading