Skip to content

Fix restoring cloud conversation transcripts#10385

Merged
seemeroland merged 1 commit into
masterfrom
roland/fix-restore-convo-transcripts
May 7, 2026
Merged

Fix restoring cloud conversation transcripts#10385
seemeroland merged 1 commit into
masterfrom
roland/fix-restore-convo-transcripts

Conversation

@seemeroland
Copy link
Copy Markdown
Contributor

@seemeroland seemeroland commented May 7, 2026

Description

Fix cloud conversation transcript viewer pane getting permanently stuck in the loading state after quit and restart.

When a pane was viewing a cloud conversation transcript (from an ambient agent run), the pane is saved as an AmbientAgent snapshot. On restore, it creates a loading pane and defers restoration until task data arrives from the server. The deferred handler calls fetch_and_load_transcript, which used a two-step lookup: first find_conversation_id_by_server_token to map the server token to a local AIConversationId, then load_conversation_data. If the conversation's metadata wasn't included in the initial cloud metadata fetch (e.g., 3 requested but only 2 returned), the token was never found locally. The task was re-inserted into the pending restorations map, but no further events fired to retry — leaving the pane stuck in Loading forever.

The fix switches fetch_and_load_transcript to use load_conversation_by_server_token, which already has a built-in server fallback when the token isn't in the local cache.

Testing

  • Quit Warp while a pane is viewing a cloud conversation transcript

  • Restart Warp

  • Verify the pane loads the conversation transcript instead of staying in the loading spinner

  • I have manually tested my changes locally with ./script/run

https://www.loom.com/share/58201254f6014ef496b25fbe78472eb6

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Changelog Entries for Stable

CHANGELOG-BUG-FIX: Fixed cloud conversation transcript pane getting stuck in loading state after restarting Warp

@cla-bot cla-bot Bot added the cla-signed label May 7, 2026
@seemeroland seemeroland requested a review from harryalbert May 7, 2026 17:43
@seemeroland seemeroland marked this pull request as ready for review May 7, 2026 17:43
@seemeroland seemeroland changed the title Fix restoring conversation transcripts Fix restoring cloud conversation transcripts May 7, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 7, 2026

@seemeroland

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@harryalbert harryalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for fixing

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR updates restored ambient-agent transcript panes to load by server conversation token, allowing the history model to fall back to a direct server fetch when local metadata does not contain the token.

Concerns

  • No blocking correctness, error handling, or security concerns found in the reviewed diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@seemeroland seemeroland merged commit 92cb3d1 into master May 7, 2026
61 checks passed
@seemeroland seemeroland deleted the roland/fix-restore-convo-transcripts branch May 7, 2026 18:25
trungtai1805 pushed a commit to trungtai1805/warp that referenced this pull request May 9, 2026
tungd pushed a commit to tungd/warp that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants