fix cloud background + status styling for cloud conversations#10511
Merged
harryalbert merged 1 commit intoMay 8, 2026
Merged
Conversation
harryalbert
changed the title
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR changes cloud conversation status styling so the cloud overlay uses the theme foreground color while cloud status icons use background-blended ANSI colors; other status surfaces continue using standard foreground-blended colors.
Concerns
- No blocking correctness or security concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
harryalbert
force-pushed
the
harry/app-4410-fix-cloud-styling-in-agent-icon-status-component
branch
from
c4ad9ce to
ea0723e
Compare
harryalbert
deleted the
harry/app-4410-fix-cloud-styling-in-agent-icon-status-component
branch
trungtai1805
pushed a commit
to trungtai1805/warp
that referenced
this pull request
May 9, 2026
…tdev#10511) ## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> WISOTT. The original figma called for the cloud to have `foreground` color, but the status icon wasn't standing out against that color at all times. To fix this, we're changing it so that the cloud bg is `foreground` but the status colors (just in the cloud case) use `ansi_bg_<color>` instead of the base ansi color (the bg variants are made to stand out against the foreground). ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/8c5668b9293d4ae4a0adf08a763a530b ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
tungd
pushed a commit
to tungd/warp
that referenced
this pull request
May 11, 2026
…tdev#10511) ## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> WISOTT. The original figma called for the cloud to have `foreground` color, but the status icon wasn't standing out against that color at all times. To fix this, we're changing it so that the cloud bg is `foreground` but the status colors (just in the cloud case) use `ansi_bg_<color>` instead of the base ansi color (the bg variants are made to stand out against the foreground). ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/8c5668b9293d4ae4a0adf08a763a530b ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WISOTT. The original figma called for the cloud to have
foregroundcolor, but the status icon wasn't standing out against that color at all times. To fix this, we're changing it so that the cloud bg isforegroundbut the status colors (just in the cloud case) useansi_bg_<color>instead of the base ansi color (the bg variants are made to stand out against the foreground).Testing
./script/runScreenshots / Videos
https://www.loom.com/share/8c5668b9293d4ae4a0adf08a763a530b
Agent Mode