Remember code review panel's selected repo per pane group (#10598)

[wzc520pyfm]

Description

Closes #10598.

In a multi-repo Agent session, switching the Code Review panel's repo via the dropdown was forgotten as soon as the user navigated to a different Agent session and came back — the panel snapped back to the default repo. This PR persists the selection per pane group so it survives leaving and returning to a session.

Why

CodeReviewState.selected_repo_path lived only in memory on the single shared RightPanelView. When set_active_pane_group switched pane groups, set_available_repos would clear the carried-over selection (because the old repo wasn't in the new pane group's repo list) and the auto-select-first-repo fallback took over. There was no per-pane-group persistence, so returning to a session always reset to the default repo.

How

Added per-pane-group persistence on the existing WorkingDirectoriesModel, which already keys other right-panel state (cached CodeReviewViews, focused repo, file tree views, etc.) by pane_group_id.

• app/src/pane_group/working_directories.rs
  • New field selected_review_repo: HashMap<EntityId, PathBuf> on the local_fs model.
  • New methods get_selected_review_repo, set_selected_review_repo, clear_selected_review_repo, plus matching no-op shims for the non-local_fs build.
  • Cleared in remove_pane_group so closing a tab discards the saved value.
• app/src/workspace/view/right_panel.rs
  • set_active_pane_group now reads both the available repos and the saved selection for the new pane group, then assigns state.selected_repo_path = saved_selection before calling set_available_repos. The existing keep-or-fallback logic in set_available_repos then either restores the saved repo (when it's still present) or falls back to auto-selecting the first repo.
  • The SelectRepo action handler writes back to the model. Persistence happens only for explicit SelectRepo actions (dropdown picks and contextual opens) so the auto-selected default never overwrites an earlier manual choice.

Linked Issue

• The linked issue is labeled `ready-to-spec` or `ready-to-implement`.
• Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Closes #10598 (a triaged bug, implicitly `ready-to-implement`).

Testing

Three regression tests added in `app/src/pane_group/working_directories_tests.rs`:

1. `selected_review_repo_is_remembered_per_pane_group` — selections in different pane groups are independent and overwriting one doesn't touch the other.
2. `selected_review_repo_is_cleared_when_pane_group_is_removed` — closing a tab clears its saved selection.
3. `clear_selected_review_repo_removes_only_the_targeted_pane_group_entry` — explicit clear is scoped.

Local checks:

• `cargo nextest run -p warp -E 'test(selected_review_repo) | test(refresh_working_directories)'` — 5 passed (3 new + 2 existing).

• `cargo fmt -- --check` — clean.

• `cargo clippy -p warp --all-targets --tests -- -D warnings` — clean.

• I have manually tested my changes locally with `./script/run`

Screenshots / Videos

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Code Review panel now remembers the manually-selected Git repository when leaving and returning to an Agent session in a multi-repo workspace.

Made with Cursor

[oz-for-oss]

@wzc520pyfm

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @vkodithala.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR adds per-pane-group storage for the code review panel's manually selected repository and restores that saved selection when returning to a pane group. It also clears the saved value when a pane group is removed and adds focused model-level regression coverage.

Concerns

• No blocking concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[kevinchevalier]

This works great. Thank you for the contribution.