[REMOTE-1470] Right-align Open in Warp button in snapshot footer#10667
Merged
dmichelin merged 1 commit intoMay 11, 2026
Merged
Conversation
Use Expanded for the left column in ConversationEndedTombstoneView so the Open in Warp button is right-aligned in the shared snapshot footer. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR updates the shared session snapshot footer layout by replacing the left column wrapper with Expanded so the action button can sit at the right edge.
Concerns
- Manual testing is required for changes that can be manually tested. Please include screenshots or a screen recording that show the shared session snapshot footer working end to end, or justify why manual testing is not possible.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
jasonkeung
approved these changes
May 11, 2026
dmichelin
deleted the
dan/remote-1470-snapshot-footer-open-in-warp-alignment
branch
cephalonaut
pushed a commit
that referenced
this pull request
May 12, 2026
) ## Description In the shared session snapshot footer (`ConversationEndedTombstoneView`), the `Open in Warp` button was not right-aligned because the left content column used `Shrinkable`. This switches the left column wrapper to `Expanded`, so the text column takes remaining row width and the action button is pinned to the right edge. ## Linked Issue REMOTE-1470 ## Testing - `cargo fmt --all` - `cargo check -p warp` - `cargo clippy -p warp --lib -- -D warnings` - `cargo clippy -p warp --all-targets --all-features -- -D warnings` *(fails in this environment due missing generated channel config JSON files in `OUT_DIR`, unrelated to this diff)* - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <img width="2243" height="241" alt="image" src="https://github.com/user-attachments/assets/ec4f2006-2fb1-4729-b85a-aa2c9bc93405" /> ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode CHANGELOG-BUG-FIX: Right-aligned the `Open in Warp` button in the shared session snapshot footer. Co-Authored-By: Oz <oz-agent@warp.dev> Co-authored-by: Oz <oz-agent@warp.dev>
dagmfactory
pushed a commit
that referenced
this pull request
May 12, 2026
) ## Description In the shared session snapshot footer (`ConversationEndedTombstoneView`), the `Open in Warp` button was not right-aligned because the left content column used `Shrinkable`. This switches the left column wrapper to `Expanded`, so the text column takes remaining row width and the action button is pinned to the right edge. ## Linked Issue REMOTE-1470 ## Testing - `cargo fmt --all` - `cargo check -p warp` - `cargo clippy -p warp --lib -- -D warnings` - `cargo clippy -p warp --all-targets --all-features -- -D warnings` *(fails in this environment due missing generated channel config JSON files in `OUT_DIR`, unrelated to this diff)* - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <img width="2243" height="241" alt="image" src="https://github.com/user-attachments/assets/ec4f2006-2fb1-4729-b85a-aa2c9bc93405" /> ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode CHANGELOG-BUG-FIX: Right-aligned the `Open in Warp` button in the shared session snapshot footer. Co-Authored-By: Oz <oz-agent@warp.dev> Co-authored-by: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the shared session snapshot footer (
ConversationEndedTombstoneView), theOpen in Warpbutton was not right-aligned because the left content column usedShrinkable.This switches the left column wrapper to
Expanded, so the text column takes remaining row width and the action button is pinned to the right edge.Linked Issue
REMOTE-1470
Testing
cargo fmt --allcargo check -p warpcargo clippy -p warp --lib -- -D warningscargo clippy -p warp --all-targets --all-features -- -D warnings(fails in this environment due missing generated channel config JSON files inOUT_DIR, unrelated to this diff)I have manually tested my changes locally with
./script/runScreenshots / Videos
Agent Mode
CHANGELOG-BUG-FIX: Right-aligned the
Open in Warpbutton in the shared session snapshot footer.Co-Authored-By: Oz oz-agent@warp.dev