Fix panick when file watcher failed to get created

[kevinyang372]

Description

Fixes APP-4438

File watcher creation could fail if we hit some system resource limit (e.g. file watcher limit on Linux). Instead of panicking, we should handle it gracefully

[oz-for-oss]

@kevinyang372

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[kevinyang372]

• Fix panick when file watcher failed to get created #10682 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

Overview

This PR changes filesystem watcher initialization so a watcher creation failure returns an error and logs file watching as disabled instead of panicking. Subsequent watch registration calls should fail through the existing channel error path once the background thread exits.

Concerns

• No blocking correctness, error-handling, performance, or security concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz