fix: enable blocklist markdown table rendering by default#10683
Conversation
Co-Authored-By: Sathvik Vangavolu <113149539+vikvang@users.noreply.github.com> Co-Authored-By: Oz <oz-agent@warp.dev>
zachlloyd
force-pushed
the
oz-agent/implement-issue-10680
branch
from
2ee1140 to
c86e9ea
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR promotes block-list Markdown table rendering by enabling the Cargo feature in the default feature set and removing the corresponding runtime flag from Preview defaults. The wiring is consistent with the intended promotion, and I did not find security concerns in the changed lines.
Concerns
- This is a user-facing rendering behavior change, but the PR does not include screenshots or a screen recording demonstrating the default/Stable table rendering end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| "github_pr_prompt_chip", | ||
| "conversations_as_context", | ||
| "markdown_tables", | ||
| "blocklist_markdown_table_rendering", |
There was a problem hiding this comment.
| FeatureFlag::BlocklistMarkdownTableRendering, | ||
| FeatureFlag::MarkdownTables, | ||
| ]; | ||
| pub const PREVIEW_FLAGS: &[FeatureFlag] = &[FeatureFlag::MarkdownTables]; |
There was a problem hiding this comment.
can remove MarkdownTables from here too, right? it's the line above the one you added in the default features list in app/Cargo.toml.
There was a problem hiding this comment.
Co-Authored-By: Oz <oz-agent@warp.dev>
|
oh this wasn't on stable? I assumed we launched this a while ago lol |
that makes two of us lol. my bad |
4 participants
Description
Enable
blocklist_markdown_table_renderingin the app's default feature set so Stable builds use the structured WarpUI renderer for Markdown tables in AI block-list responses.This removes
FeatureFlag::BlocklistMarkdownTableRenderingfromPREVIEW_FLAGSnow that the Cargo feature is default-enabled. The runtime flag remains in place for now so rollback is still a one-line default-feature removal if needed.Linked Issue
Closes #10680
ready-to-specorready-to-implement.Testing
cargo fmt --all --checkcargo check --manifest-path /workspace/warp/Cargo.toml -p warp_featurescargo check --manifest-path /workspace/warp/Cargo.toml -p warp --bin stable --features guicargo clippy --manifest-path /workspace/warp/Cargo.toml -p warp_features -- -D warningscargo clippy --manifest-path /workspace/warp/Cargo.toml -p warp --bin stable --features gui -- -D warningsNo new automated tests were added because this is a feature promotion wiring change; the structured table parser/renderer behavior is covered by the existing implementation tests.
./script/runScreenshots / Videos
N/A — feature flag/default build wiring change only.
Agent Mode
CHANGELOG-BUG-FIX: AI responses that contain Markdown tables now render as structured tables in Stable instead of monospaced pipe-table blocks.
Conversation: https://staging.warp.dev/conversation/4779e51d-33fd-4171-9481-b4b3e5612ddf
Run: https://oz.staging.warp.dev/runs/019e700f-c1eb-76c9-a179-d577563b8273
This PR was generated with Oz.