downrank the Broadcom V3D Vulkan driver#10688
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
| cfg!(target_os = "linux") | ||
| && adapter_info.backend == wgpu::Backend::Vulkan | ||
| && adapter_info.driver.contains("V3DV") | ||
| && adapter_info.name.starts_with("V3D 4.2.14.") |
There was a problem hiding this comment.
it's a 4-part version number and we're specifically targeting versions 4.2.14.* as that is the version that appeared in the logs in our user reports. We don't know exactly which versions are affected so this is a start.
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds a Linux adapter-stability rule to deprioritize Broadcom V3D/V3DV Vulkan adapters so affected Raspberry Pi users can fall back to OpenGL.
Concerns
- The new adapter-name predicate is narrower than the stated Broadcom V3D Vulkan-driver fix, so V3DV adapters reported with a different V3D revision or exact name can remain preferred over OpenGL.
- Manual testing evidence is missing for this user-visible rendering/backend behavior change. Please include screenshots or a screen recording from an affected Raspberry Pi showing Warp starts and renders end to end, or justify why that testing is not possible.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
not blocking: Now that we're open source, I'd love to figure out a way to knowledge share with the wgpu maintainers. We have a lot of reports of problematic adapters that would be useful for them to improve the library (if it is indeed a wgpu bug and not a Warp bug) |
3 participants
Description
This PR down-ranks another troublesome adapter. We have multiple reports of Warp having issues on RPi with Vulkan but working fine with OpenGL.
Linked Issue
This closes #4879, #10618, and possibly #10571.
Testing
Not tested but users have already confirmed that adding
WGPU_BACKEND=glfixes their issues.CHANGELOG-BUG-FIX: [Linux] Fix Warp on Raspberry pi.