[Tab configs] make tab configs run commands sequentially#10698
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
moirahuang
force-pushed
the
moira/sequential-tab-config-commands
branch
from
30642df to
f864be6
Compare
moirahuang
force-pushed
the
moira/sequential-tab-config-commands
branch
from
f864be6 to
c30ae2b
Compare
moirahuang
force-pushed
the
moira/sequential-tab-config-commands
branch
from
c30ae2b to
6166bf6
Compare
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR changes tab configs to submit saved commands as sequential pending-command blocks while preserving the legacy chained && behavior for launch configs. It adds command execution mode metadata, updates tab config rendering/resolution to opt into sequential blocks, and extends terminal pending-command tracking so queued commands advance only after successful user blocks.
Concerns
- No blocking correctness or security concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR introduces a command execution mode on pane templates so launch configs keep the legacy && behavior while tab configs submit commands as separate pending blocks. It wires the sequential mode through tab config rendering, pane construction, pending-command scheduling, and command-completion handling.
Concerns
- No blocking correctness or security concerns found in the reviewed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
…10698) ## Description It was flagged in our preview Slack that tab configs that run a worktree + a long running command like `opencode` will make the Warp UI such as project explorer and code review panel show the original directory, not the worktree directory: https://warpcommunity.slack.com/archives/C092WE7HDH9/p1778148593003159 This is because we execute all the `commands` in the tab config in one go with `&&` between commands so the UI doesn't refresh the current working directory. I considered 2 options: 1) overwriting `cd` 2) making the commands fire sequentially. I went with 2 since it felt less brittle but if users really dislike the UX, we can consider going back Note: launch configs were also built to run commands in one go with `&&` appending the commands. I decided to not change that existing behavior since launch configs are not in active development anymore but I'm not entirely opposed to having consistent behavior between the 2 ## Testing Locally ran and confirmed that w sequentially run commands from a tab confg - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos https://github.com/user-attachments/assets/632126d5-d5d4-410e-8350-0e966b8177fc ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
2 participants
Description
It was flagged in our preview Slack that tab configs that run a worktree + a long running command like
opencodewill make the Warp UI such as project explorer and code review panel show the original directory, not the worktree directory: https://warpcommunity.slack.com/archives/C092WE7HDH9/p1778148593003159This is because we execute all the
commandsin the tab config in one go with&&between commands so the UI doesn't refresh the current working directory. I considered 2 options: 1) overwritingcd2) making the commands fire sequentially. I went with 2 since it felt less brittle but if users really dislike the UX, we can consider going backNote: launch configs were also built to run commands in one go with
&&appending the commands. I decided to not change that existing behavior since launch configs are not in active development anymore but I'm not entirely opposed to having consistent behavior between the 2Testing
Locally ran and confirmed that w sequentially run commands from a tab confg
./script/runScreenshots / Videos
Screen.Recording.2026-05-11.at.6.25.38.PM.mov
Agent Mode