Add more hints for local -> cloud handoff entrypoint#10834
Conversation
harryalbert
changed the title
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds local-to-cloud handoff discoverability in agent tips, the handoff chip tooltip, and the agent-view zero-state shortcut row.
Concerns
- The new clickable
&hint is shown when cloud handoff is enabled, but not when the ampersand entrypoint itself is enabled; this can advertise and activate the disabled&entrypoint.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| @@ -580,6 +583,33 @@ impl MessageProvider<AgentMessageArgs<'_>> for ZeroStateMessageProducer { | |||
| AgentViewState::Active { origin, .. } if origin.is_cloud_agent() | |||
| ); | |||
|
|
|||
There was a problem hiding this comment.
& entrypoint, but it is only gated on general cloud handoff availability; when is_ampersand_handoff_enabled is false, the hint still appears and clicking it bypasses the disabled ampersand path. Gate this row on AISettings::as_ref(app).is_ampersand_handoff_enabled(app) and apply the same ampersand-specific gate to the other new & copy surfaces.
There was a problem hiding this comment.
Yeah this is true, but the settings gate is just to prevent folks like Andy from getting frustrated where typing & auto-enters handoff mode
There was a problem hiding this comment.
I do think it probably makes sense to also hide this if you've turned the setting off (because if you've turned it off you clearly know about the feature)
harryalbert
force-pushed
the
harry/app-4473-add-better-hintsentrypoints-for-local-cloud-handoff
branch
from
b14f4f2 to
cf1e6ca
Compare
harryalbert
deleted the
harry/app-4473-add-better-hintsentrypoints-for-local-cloud-handoff
branch
## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> This PR adds a few more hints/pieces of discoverability for local -> cloud. Specifically, it adds: * a tip about `&` to the list of tips that we show below the warping indicator * a note about the `&` entrypoint to the handoff chip * a note about the `&` entrypoint to the keybinding list above the input in the agent view (replacing the code review note) ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/0b7b9aad8e7e4e209bce09c887ab1c1e ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
2 participants
Description
This PR adds a few more hints/pieces of discoverability for local -> cloud. Specifically, it adds:
&to the list of tips that we show below the warping indicator&entrypoint to the handoff chip&entrypoint to the keybinding list above the input in the agent view (replacing the code review note)Testing
./script/runScreenshots / Videos
https://www.loom.com/share/0b7b9aad8e7e4e209bce09c887ab1c1e
Agent Mode