Skip to content

Send custom endpoints to server#10894

Merged
dagmfactory merged 1 commit into
masterfrom
daniel/send-custom-endpoints
May 14, 2026
Merged

Send custom endpoints to server#10894
dagmfactory merged 1 commit into
masterfrom
daniel/send-custom-endpoints

Conversation

@danielpeng2
Copy link
Copy Markdown
Member

@danielpeng2 danielpeng2 commented May 14, 2026

Description

We were hardcoding custom model providers to None instead of passing up the actual list.

@cla-bot cla-bot Bot added the cla-signed label May 14, 2026
Copy link
Copy Markdown
Member Author

danielpeng2 commented May 14, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@danielpeng2 danielpeng2 requested a review from dagmfactory May 14, 2026 06:59
@danielpeng2 danielpeng2 marked this pull request as ready for review May 14, 2026 06:59
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 14, 2026

@danielpeng2

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR forwards the existing RequestParams.custom_model_providers registry into the multi-agent API request settings instead of always sending None.

Concerns

  • No blocking correctness or security concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@dagmfactory dagmfactory merged commit e12c35e into master May 14, 2026
49 checks passed
@dagmfactory dagmfactory deleted the daniel/send-custom-endpoints branch May 14, 2026 14:26
lawsmd pushed a commit to lawsmd/cortex that referenced this pull request May 22, 2026
## Description
<!-- Please remember to add your design buddy onto the PR for review, if
it contains any UI changes! -->

We were hardcoding custom model providers to `None` instead of passing
up the actual list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants