Skip to content

Rename FileLocation to LocalOrRemotePath#10909

Merged
MaggieShan merged 1 commit into
masterfrom
maggs/rename-file-location
May 14, 2026
Merged

Rename FileLocation to LocalOrRemotePath#10909
MaggieShan merged 1 commit into
masterfrom
maggs/rename-file-location

Conversation

@MaggieShan
Copy link
Copy Markdown
Contributor

@MaggieShan MaggieShan commented May 14, 2026

Description

  • WISOTT
  • To clarify the intent of the type and avoid the overlapping FileLocation names that are also used in agent and notebook types

Testing

Should be a no-op

  • I have manually tested my changes locally with ./script/run

@cla-bot cla-bot Bot added the cla-signed label May 14, 2026
@MaggieShan MaggieShan changed the title Rename file location Rename FileLocation to LocalOrRemotePath May 14, 2026
@MaggieShan MaggieShan marked this pull request as ready for review May 14, 2026 15:39
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 14, 2026

@MaggieShan

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@MaggieShan MaggieShan requested a review from kevinyang372 May 14, 2026 15:45
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR mechanically renames the code buffer file identity type from FileLocation to LocalOrRemotePath across the editor, file tree, workspace, pane, code review, and persistence test call sites. The changed hunks preserve the existing local/remote variants and behavior.

Concerns

  • No blocking concerns found.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@MaggieShan MaggieShan enabled auto-merge (squash) May 14, 2026 15:48
@MaggieShan MaggieShan merged commit 5a9bf67 into master May 14, 2026
53 checks passed
@MaggieShan MaggieShan deleted the maggs/rename-file-location branch May 14, 2026 15:54
lawsmd pushed a commit to lawsmd/cortex that referenced this pull request May 22, 2026
## Description
* WISOTT 
* To clarify the intent of the type and avoid the overlapping
FileLocation names that are also used in agent and notebook types

## Testing
Should be a no-op
-  [x] I have manually tested my changes locally with `./script/run`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants