[QUALITY-648] Maybe close message previews by default#10935
Conversation
Collapse orchestration message bodies by default while keeping start-agent prompts expanded. Add focused AI block tests covering the new collapsible-state defaults. Co-Authored-By: Oz <oz-agent@warp.dev>
…maybe-close-message-previews-by-default
Run cargo fmt after merging origin/master into the AI block module changes. Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR collapses orchestration send-message and received-agent message bodies by default, keeps StartAgent prompts expanded, and adds focused unit coverage.
Concerns
⚠️ [IMPORTANT] This is a user-facing behavior change, but the PR has no screenshot or short recording demonstrating the collapsed message previews end to end. Please attach visual evidence for review.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
Added the requested screenshot for the user-visible collapse behavior. This capture shows:
|
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR changes orchestration transcript rendering so sent-message bodies and received-agent message rows start collapsed while StartAgent prompts remain expanded, with focused unit coverage for the default state helper. No security concerns were identified in the diff.
Concerns
- This is a user-facing behavior change, but the PR description states screenshots/videos are not included. For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates AI block collapsible-state defaults so orchestration send-message bodies and received-agent message rows start collapsed, while StartAgent prompts keep the existing expanded default. It also adds focused unit coverage for the helper-level defaults.
Concerns
- No blocking concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
…views-by-default Co-Authored-By: Oz <oz-agent@warp.dev>
kjankov
deleted the
katarina/quality-648-maybe-close-message-previews-by-default
branch
## Description - Collapse orchestration message bodies by default so multi-agent transcripts are less noisy on first render. - Keep `StartAgent` prompts expanded by default while applying the collapsed default to `SendMessageToAgent` output and received-agent message rows. - Add focused AI block unit coverage for the new collapse-default behavior. ## Linked Issue - Linear: [QUALITY-648](https://linear.app/warpdotdev/issue/QUALITY-648/maybe-close-message-previews-by-default) - [ ] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. - [x] Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). ## Testing - [ ] I have manually tested my changes locally with `./script/run` - `cargo fmt` - `cargo clippy --workspace --all-targets --all-features --tests -- -D warnings` - `cargo test -p warp block::tests --lib` ### Screenshots / Videos - Screenshot of the collapsed orchestration message previews end to end:  ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode ## Artifacts - Conversation: https://app.warp.dev/conversation/4e2fa677-3c3c-46e3-b834-6b0487a1e1f9 - Plan: [Make orchestration messages collapsed by default](https://app.warp.dev/drive/notebook/B00gaFErILl9rPmGi1PDYs) CHANGELOG-NONE Co-Authored-By: Oz <oz-agent@warp.dev> --------- Co-authored-by: Oz <oz-agent@warp.dev>
2 participants
Description
StartAgentprompts expanded by default while applying the collapsed default toSendMessageToAgentoutput and received-agent message rows.Linked Issue
ready-to-specorready-to-implement.Testing
./script/runcargo fmtcargo clippy --workspace --all-targets --all-features --tests -- -D warningscargo test -p warp block::tests --libScreenshots / Videos
Agent Mode
Artifacts
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev