fix: hide handoff details panel by default

[captainsafia]

Description

Hide the conversation details panel by default when a local-to-cloud handoff joins the cloud session share. Normal shared ambient agent session joins still auto-open the details panel.

Linked Issue

• The linked issue is labeled ready-to-spec or ready-to-implement.
• Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Slack request: D0AU96L8CDV / 1778785222.326509

Testing

• CARGO_BUILD_JOBS=1 cargo nextest run --manifest-path /workspace/warp/Cargo.toml -p warp -E 'test(test_ambient_session_join_auto_opens_details_panel) | test(test_local_to_cloud_handoff_session_join_keeps_details_panel_hidden)' -j 1

• cargo fmt --manifest-path /workspace/warp/Cargo.toml --all -- --check

• I have manually tested my changes locally with ./script/run

Screenshots / Videos

Demo: https://www.loom.com/share/c555f624fcea4937b3611144dd5ee8a5

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Hide the conversation details panel by default when moving a local Warp Agent conversation to cloud.

Co-Authored-By: Oz oz-agent@warp.dev

Conversation: https://staging.warp.dev/conversation/8f301dfc-0625-4230-b7aa-b49c362c78f9
Run: https://oz.staging.warp.dev/runs/019e27dc-84f5-79ff-8778-e89699d2ef96
This PR was generated with Oz.

[oz-for-oss]

@captainsafia

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR adds a local-to-cloud handoff guard around the shared ambient-session join auto-open behavior and adds tests for normal ambient joins and handoff joins.

Concerns

• The new guard only covers on_session_share_joined; local-to-cloud handoff panes can still auto-open the details panel from the earlier AmbientAgentViewModelEvent::SessionReady handler before the shared-session join path runs.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

⚠️ [IMPORTANT] This only suppresses the join-time auto-open, but local-to-cloud handoff panes also receive AmbientAgentViewModelEvent::SessionReady before the manager joins the shared session, and that handler still calls maybe_auto_open_conversation_details_panel when HandoffCloudCloud is disabled. Add the same handoff guard there or the panel can open before this branch runs.

[harryalbert]

huh, I thought @zachbai already fixed this

[captainsafia]

huh, I thought @zachbai already fixed this

I thought so as well but I ran into it while bug bashing earlier. Do you happen to know the PR that originally fixed it?

[zachbai]

Yea its definitely not fixed, we should merge this