Add horizontal scrolling for orchestration pill bar#10957
Conversation
Makes the orchestration pill bar horizontally scrollable when there are more child agents than the pane can fit. Adds click-and-drag, trackpad side-swipe, and bare mouse-wheel panning. Pull the scroll position into the shared singleton so navigating between sibling panes preserves the user's scroll offset, and apply the same thin hairline scrollbar to the split-off pane breadcrumb row. Also fixes a hit-target collision between the pane's drag handler and the new scrollbar by narrowing the draggable region to just the title row, mirroring the pattern already used by the code view. Co-Authored-By: Oz <oz-agent@warp.dev>
advait-m
changed the title
…remap intent Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
Reviewed the horizontal scroll support for the orchestration pill bar and breadcrumbs, the shared pill-bar model state, the narrower pane-header drag region, and the opt-in cross-axis wheel remapping.
Concerns
- None found in the changed lines. The user-facing visual evidence requirement is satisfied by the Loom link in the PR body.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| .with_horizontal_scrollbar(ScrollableAppearance::new(ScrollbarWidth::Custom(4.), true)) | ||
| // Let a standard vertical mouse wheel pan the bar horizontally; | ||
| // trackpad horizontal swipes already work through the default path. | ||
| .with_remap_cross_axis_wheel_to_main_axis(true) |
There was a problem hiding this comment.
As a scroll wheel user, this is great!
There was a problem hiding this comment.
fellow mice users unite!!
2 participants
Loom: https://www.loom.com/share/d084bf3c39814a459ad0f3bfc3cda539
Fixes https://linear.app/warpdotdev/issue/QUALITY-710/add-horizontal-scroll-bar-to-pill-bar
Description
Makes the orchestration pill bar horizontally scrollable when it overflows the pane width via scrollbar drag, trackpad swipe, or vertical mouse wheel. Scrollbar is a 4px overlaid hairline so the bar height stays constant. Same treatment applied to the breadcrumb row in split-off panes for visual consistency.
Scroll position is shared across sibling panes in the same orchestration tree (different orchestrators each get their own). The mouse-wheel-to-horizontal-scroll behaviour is a new opt-in builder flag on the shared scrollable element — no-op for everyone who doesn't ask for it. Also narrows the pane header's drag region to just the title row so the new scrollbar thumb isn't eaten by the drag handler (mirrors the code view's tabbed header pattern).
Testing
./script/run