Skip to content

Fix pkill process completions#10974

Closed
maro20066600 wants to merge 1 commit into
warpdotdev:masterfrom
maro20066600:maro/fix-pkill-process-completions
Closed

Fix pkill process completions#10974
maro20066600 wants to merge 1 commit into
warpdotdev:masterfrom
maro20066600:maro/fix-pkill-process-completions

Conversation

@maro20066600
Copy link
Copy Markdown
Contributor

Fixes #10924

Summary

  • Add a pkill command signature backed by process-name completions.
  • Prevent pkill from falling back to filesystem paths when process completions are unavailable.
  • Apply the fallback guard to both legacy and v2 argument completion paths.

Tests

  • cargo fmt --check
  • PATH="/tmp/codex-fake-xcrun:$PATH" cargo test -p warp_completer pkill --features test-util
  • PATH="/tmp/codex-fake-xcrun:$PATH" cargo test -p warp_completer pkill --features 'test-util v2'

@cla-bot cla-bot Bot added the cla-signed label May 15, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 15, 2026

@maro20066600

This PR is not linked to an issue that is marked with ready-to-implement.

Issue-state enforcement details:

Readiness check:

To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maro20066600

This PR is not linked to an issue that is marked with ready-to-implement.

Issue-state enforcement details:

  • Associated same-repo issues checked: #10924

  • Required readiness label: ready-to-implement

Readiness check:

  • #10924: missing ready-to-implement; readiness labels present: none

To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 15, 2026
@maro20066600
Copy link
Copy Markdown
Contributor Author

Thanks for the note.

This PR is linked to #10924 and implements a fix for the reported pkill <TAB> filesystem fallback behavior.

Could a maintainer please confirm whether #10924 can be marked as ready-to-implement, or let me know if a different implementation direction is preferred?

Happy to adjust.

@vorporeal
Copy link
Copy Markdown
Contributor

hi @maro20066600 - changes to command signatures can be made in the https://github.com/warpdotdev/command-signatures repo

@vorporeal vorporeal closed this May 15, 2026
@vorporeal
Copy link
Copy Markdown
Contributor

vorporeal commented May 15, 2026

oops, sorry, github didn't show me the comment where you asked for input - yeah, we'll definitely accept a command signature update for pkill! a maintainer can review the contribution to the command-signatures repo, and then we'll need a PR here to update our dependency on warp-command-signatures to include your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pkill <TAB> completes filesystem paths instead of process names in Warp

2 participants