ship updated conpty built from warpdotdev/v1.24.11321.0#10976
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the bundled Windows ConPTY/OpenConsole binaries for both x64 and arm64 to address Ctrl-C behavior when exiting opencode. The provided diff is binary-only and GitHub did not expose a reviewable patch for any changed file, so review is limited to the PR description and changed asset paths.
Concerns
⚠️ [IMPORTANT] [SECURITY] The PR replaces shipped Windows executable/DLL artifacts without reviewable provenance in the provided context. Please attach the source commit/tag diff used for the build, build logs or CI run, SHA-256 hashes for all four committed artifacts, and any signing/scanning verification so reviewers can confirm the binaries matchwarpdotdev/v1.24.11321.0and were produced by the expected process.⚠️ [IMPORTANT] This is a user-facing behavioral change, so please include a short screen recording demonstrating that pressing Ctrl-C exitsopencodewithout closing the Warp session on Windows.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
2 participants
Description
This PR adds freshly built Windows Console assets (ConPTY and OpenConsole) from a rebased version of our fork onto the latest stable release.
Built from this branch: https://github.com/warpdotdev/microsoft-terminal/tree/warpdotdev/v1.24.11321.0
The motivation is to fix a bug affecting
opencodeusers where pressing ctrl-c to exit open code erroneously closes the whole session.Linked Issue
Closes #8670 and #10051
Testing
I ran this in a local build and ran
opencode. Exiting with ctrl-c no longer kills the session.