[1/5] [Remote codebase indexing] pass embedding configs through#10981
[1/5] [Remote codebase indexing] pass embedding configs through#10981moirahuang wants to merge 1 commit into
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
a9de6aa to
e1d12c7
Compare
There was a problem hiding this comment.
Overview
This PR threads the embedding configuration through remote codebase indexing status/proto conversions, uses it when constructing the remote search context, and separates request-vs-resync actions for remote index refreshes in settings.
Concerns
- No blocking correctness or security concerns found in the reviewed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
kevinyang372
left a comment
There was a problem hiding this comment.
On a high-level, does this need to pass through proto? The client gets the embedding config through the server anyway. So the remote server binary should be able to do the same no?
ce439ff to
226c97d
Compare
64c23fe to
d6a352f
Compare
226c97d to
cac7a24
Compare
26473fc to
f55b80e
Compare
cac7a24 to
84d35c0
Compare
e78aaf6 to
a80a6e3
Compare
Co-Authored-By: Oz <oz-agent@warp.dev>
a80a6e3 to
4be2eaa
Compare

Description
Passing embedding configs through for remote codebase indexing
Also made a small update to the refresh icon for remote envs to distinguish when there's already an index vs. when we need to create an index
Testing
Added unit tests + locally tested
./script/runScreenshots / Videos
Agent Mode