Skip to content

[1/5] [Remote codebase indexing] pass embedding configs through#10981

Open
moirahuang wants to merge 1 commit into
masterfrom
moira/codebase-indexing-ui-followups
Open

[1/5] [Remote codebase indexing] pass embedding configs through#10981
moirahuang wants to merge 1 commit into
masterfrom
moira/codebase-indexing-ui-followups

Conversation

@moirahuang
Copy link
Copy Markdown
Contributor

@moirahuang moirahuang commented May 15, 2026

Description

Passing embedding configs through for remote codebase indexing

Also made a small update to the refresh icon for remote envs to distinguish when there's already an index vs. when we need to create an index

Testing

Added unit tests + locally tested

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

Screenshot 2026-05-14 at 8 17 05 PM

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label May 15, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 15, 2026

@moirahuang

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@moirahuang moirahuang force-pushed the moira/codebase-indexing-ui-followups branch 2 times, most recently from a9de6aa to e1d12c7 Compare May 15, 2026 03:20
@moirahuang moirahuang requested a review from kevinyang372 May 15, 2026 03:21
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR threads the embedding configuration through remote codebase indexing status/proto conversions, uses it when constructing the remote search context, and separates request-vs-resync actions for remote index refreshes in settings.

Concerns

  • No blocking correctness or security concerns found in the reviewed diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Member

@kevinyang372 kevinyang372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a high-level, does this need to pass through proto? The client gets the embedding config through the server anyway. So the remote server binary should be able to do the same no?

@moirahuang moirahuang force-pushed the moira/codebase-indexing-ui-followups branch from ce439ff to 226c97d Compare May 15, 2026 18:45
@moirahuang moirahuang requested a review from kevinyang372 May 15, 2026 18:45
@moirahuang moirahuang force-pushed the moira/codebase-indexing-ui branch from 64c23fe to d6a352f Compare May 15, 2026 19:32
@moirahuang moirahuang force-pushed the moira/codebase-indexing-ui-followups branch from 226c97d to cac7a24 Compare May 15, 2026 21:09
@moirahuang moirahuang force-pushed the moira/codebase-indexing-ui branch 2 times, most recently from 26473fc to f55b80e Compare May 15, 2026 22:00
@moirahuang moirahuang force-pushed the moira/codebase-indexing-ui-followups branch from cac7a24 to 84d35c0 Compare May 15, 2026 22:47
Base automatically changed from moira/codebase-indexing-ui to master May 15, 2026 23:24
@moirahuang moirahuang force-pushed the moira/codebase-indexing-ui-followups branch 3 times, most recently from e78aaf6 to a80a6e3 Compare May 15, 2026 23:40
@moirahuang moirahuang changed the title [Remote codebase indexing] pass embedding configs through [1/5] [Remote codebase indexing] pass embedding configs through May 16, 2026
Copy link
Copy Markdown
Contributor Author

moirahuang commented May 16, 2026

Co-Authored-By: Oz <oz-agent@warp.dev>
@moirahuang moirahuang force-pushed the moira/codebase-indexing-ui-followups branch from a80a6e3 to 4be2eaa Compare May 16, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants