Disable model selector for cloud -> cloud follow ups#11023
Conversation
harryalbert
force-pushed
the
harry/app-4461-follow-up-executions-for-3p-agents-eg-cloud-cloud-handoff-do
branch
from
30800c3 to
7793411
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR wires the inline model selector to use third-party harness availability and store selections on the ambient agent view model for cloud follow-up panes.
Concerns
- Selecting a third-party harness model only updates client-side ambient state; the cloud follow-up submission path still sends a request containing only the prompt message, so the selected model is not applied to the follow-up run.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
harryalbert
changed the title
harryalbert
force-pushed
the
harry/app-4461-follow-up-executions-for-3p-agents-eg-cloud-cloud-handoff-do
branch
2 times, most recently
from
43d37fa to
f5968e8
Compare
harryalbert
force-pushed
the
harry/app-4461-follow-up-executions-for-3p-agents-eg-cloud-cloud-handoff-do
branch
from
7c5a4ee to
3658834
Compare
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds ambient-agent lifecycle tracking and uses it to lock the profile model selector for cloud follow-up and non-Oz cloud run states.
Concerns
- The selector lock is not refreshed when a task ID is first assigned during normal cloud spawn, so non-Oz runs can remain interactive until a later session event.
- The toggle guard does not cover an already-open model menu, which can still dispatch model selections after the selector becomes locked.
- For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.
Verdict
Found: 0 critical, 3 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
harryalbert
force-pushed
the
harry/app-4461-follow-up-executions-for-3p-agents-eg-cloud-cloud-handoff-do
branch
from
08385d4 to
bf9eba1
Compare
harryalbert
force-pushed
the
harry/app-4461-follow-up-executions-for-3p-agents-eg-cloud-cloud-handoff-do
branch
from
bf9eba1 to
36e0120
Compare
harryalbert
deleted the
harry/app-4461-follow-up-executions-for-3p-agents-eg-cloud-cloud-handoff-do
branch
## Description While making a PR for fixing the model selector for 3p harnesses with cloud -> cloud handoff, I realized that the model selector doesn't really do anything for regular cloud -> cloud handoff ( confirmed w/ testing). So we should just disable it for now (threading it through the server is a much bigger job) ## Testing - [x] I have manually tested my changes locally with `./script/run` ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode _Conversation: https://staging.warp.dev/conversation/275febf2-b6ab-4a9b-9423-4938b0eda56d_ _Run: https://oz.staging.warp.dev/runs/019e2c5c-ae72-7bb7-ad71-a5c70e717870_ _Plans:_ - _[Fix model options for 3P harness cloud-to-cloud follow-ups](https://staging.warp.dev/drive/notebook/24jDZdgxkSDSxRlKf7LpMn)_ _This PR was generated with [Oz](https://warp.dev/oz)._
3 participants
Description
While making a PR for fixing the model selector for 3p harnesses with cloud -> cloud handoff, I realized that the model selector doesn't really do anything for regular cloud -> cloud handoff ( confirmed w/ testing). So we should just disable it for now (threading it through the server is a much bigger job)
Testing
./script/runAgent Mode
Conversation: https://staging.warp.dev/conversation/275febf2-b6ab-4a9b-9423-4938b0eda56d
Run: https://oz.staging.warp.dev/runs/019e2c5c-ae72-7bb7-ad71-a5c70e717870
Plans:
This PR was generated with Oz.