[QUALITY-719] Hide legacy orchestration setting for v2#11035
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates orchestration enablement so OrchestrationV2 enables the orchestration tools independently of the legacy user setting, hides the legacy toggle while v2 is active, and adds focused unit coverage for the legacy/v2 truth table. I did not find correctness or security issues in the changed logic.
Concerns
- The change removes a visible AI settings toggle when
OrchestrationV2is enabled, but the PR description does not include screenshots or a screen recording demonstrating the settings page behavior end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| )); | ||
|
|
||
| if FeatureFlag::Orchestration.is_enabled() { | ||
| if AISettings::is_orchestration_user_setting_visible() { |
There was a problem hiding this comment.
cephalonaut
changed the title
cephalonaut
changed the title
| } | ||
|
|
||
| pub(crate) fn is_orchestration_user_setting_visible() -> bool { | ||
| FeatureFlag::Orchestration.is_enabled() && !FeatureFlag::OrchestrationV2.is_enabled() |
There was a problem hiding this comment.
if it's easier, we can get rid of the v1 flag?
There was a problem hiding this comment.
Got rid of flag, but didn't clean up all affected code because I don't want to over complicate things. Filed issue to follow up.
Co-Authored-By: Oz <oz-agent@warp.dev>
Remove the v1 orchestration runtime flag and user-facing experiment setting so orchestration availability is driven by OrchestrationV2 plus global AI enablement. Leave QUALITY-733 TODOs on deferred v1 transport cleanup paths. Co-Authored-By: Oz <oz-agent@warp.dev>
cephalonaut
force-pushed
the
matthew/hide-orchestration-setting-when-v2
branch
from
352601c to
dbd839d
Compare
) ## Description Remove the legacy v1 orchestration runtime flag and experiment setting. Orchestration availability is now driven by OrchestrationV2 together with global AI enablement. The remaining v1 transport/event-service cleanup is deferred and annotated with TODO(QUALITY-733) comments. ## Linked Issue https://linear.app/warpdotdev/issue/QUALITY-733/cleanup-unneeded-v1-orchestration-code ## Testing - [x] cargo fmt - [x] cargo test -p warp orchestration_ --lib - [x] PATH="/tmp/warp-corepack-shims:$PATH" cargo clippy --workspace --all-targets --all-features --tests -- -D warnings ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode CHANGELOG-NONE Co-Authored-By: Oz <oz-agent@warp.dev> --------- Co-authored-by: Oz <oz-agent@warp.dev>
3 participants
Description
Remove the legacy v1 orchestration runtime flag and experiment setting. Orchestration availability is now driven by OrchestrationV2 together with global AI enablement.
The remaining v1 transport/event-service cleanup is deferred and annotated with TODO(QUALITY-733) comments.
Linked Issue
https://linear.app/warpdotdev/issue/QUALITY-733/cleanup-unneeded-v1-orchestration-code
Testing
Agent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev