disable dogfood custom endpoints + enable only for warp plan#11044
disable dogfood custom endpoints + enable only for warp plan#11044dagmfactory wants to merge 1 commit into
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR changes the custom inference endpoint eligibility gate so enterprise workspaces are allowed when they are on Warp Plan or the enterprise feature flag is enabled, and removes the dogfood-channel override. It also adds unit coverage for the updated billing and auth cases.
Concerns
- This is a user-facing behavior change because custom inference availability changes based on plan and auth state, but the PR description does not include screenshots or a screen recording demonstrating the setting/feature behavior end to end. Please attach screenshots or a short recording from a local desktop run, or from an environment with computer use enabled.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| || ChannelState::channel().is_dogfood() | ||
| let is_enterprise_customer = | ||
| workspace.billing_metadata.customer_type == CustomerType::Enterprise; | ||
| let is_warp_plan_billing_workspace = workspace.billing_metadata.is_warp_plan(); |
There was a problem hiding this comment.
i think is_warp_plan only works for our stable team. is there a way we can get an exception for our staging team as well?
Description
Disabled custom inference for everyone on dogfood and enabled it for users on warp plan for testing
Linked Issue
Screenshots / Videos
Agent Mode