Use fresh metadata and updated iconography for cloud agent view entry block.#11088
Use fresh metadata and updated iconography for cloud agent view entry block.#11088zachbai wants to merge 1 commit into
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the cloud agent entry block to derive better titles from conversation/task/spawn metadata and to render agent icons with ambient status fallbacks. The user-facing change includes a Loom demo link, so the visual-evidence requirement is satisfied.
Concerns
- The cancelled-run metadata fetch can be skipped when cancellation occurs before the task ID arrives, leaving the entry block stuck on fallback metadata for that supported cancellation path.
- No security findings.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| fn maybe_fetch_task_data(&mut self, ctx: &mut ViewContext<Self>) { | ||
| let Some(task_id) = self | ||
| .ambient_agent_view_model(ctx) | ||
| .and_then(AmbientAgentViewModel::task_id) |
There was a problem hiding this comment.
TaskSpawned, the first Cancelled event takes this None path, and when TaskSpawned later fills task_id that handler returns without emitting another event, so the entry block never fetches the fresh cancelled-task metadata. Trigger this fetch again once the task id is assigned, or emit an event from that cancelled TaskSpawned path.
2 participants
Description
Demo