Move feature flag initialization logic out of lib.rs.

[vorporeal]

Description

Trying to do a little codebase clean-up. We've got way too much stuff in app/src/lib.rs, which should probably be mostly (if not only?) module definitions, plus perhaps a couple public re-exports (for integration tests and such).

We already have a warp::features module (which is where the feature flags used ot be) - seems like a good place for init_feature_flags().

[vorporeal]

• Move feature flag initialization logic out of lib.rs. #11380 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves feature flag initialization helpers from app/src/lib.rs into the existing warp::features module and updates the in-crate call sites to use features::init_feature_flags().

Concerns

No blocking concerns found. No approved spec context was provided, so this review is limited to the attached diff plus correctness and security checks.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[bnavetta]

Nice! We should update the /promote-feature skill and any others that reference feature flags