Skip to content

REMOTE-1727 Surface artifact upload root cause#11386

Merged
jasonkeung merged 9 commits into
masterfrom
oz-agent/artifact-upload-error-surfacing
May 28, 2026
Merged

REMOTE-1727 Surface artifact upload root cause#11386
jasonkeung merged 9 commits into
masterfrom
oz-agent/artifact-upload-error-surfacing

Conversation

@jasonkeung
Copy link
Copy Markdown
Contributor

@jasonkeung jasonkeung commented May 20, 2026

Description

Preserves the actionable root cause when an artifact upload target request fails, so quota failures surface as an artifact upload limit message instead of only Failed to create file artifact upload target.

https://www.loom.com/share/2c05a308b87a42b981ea037234aca463
Screenshot 2026-05-27 at 2 28 29 PM

Linked Issue

REMOTE-1727

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • cargo fmt --manifest-path /workspace/warp/Cargo.toml --all -- --check

  • cargo test --manifest-path /workspace/warp/Cargo.toml -p warp format_upload_artifact_error

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

Not applicable for this focused error-copy change.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Artifact upload failures now surface actionable quota-limit details when upload limits are reached.

Co-Authored-By: Oz oz-agent@warp.dev

Conversation: https://staging.warp.dev/conversation/aa254ad4-a7ab-49b0-95d6-5af18280c54b
Run: https://oz.staging.warp.dev/runs/019e42ff-b61e-73ae-b998-29f13642cd6d
Plans:

This PR was generated with Oz.

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label May 20, 2026
@jasonkeung jasonkeung changed the title Surface artifact upload root cause REMOTE-1727 Surface artifact upload root cause May 20, 2026
jasonkeung and others added 4 commits May 20, 2026 19:52
Co-Authored-By: Oz <oz-agent@warp.dev>
Write GitHub CLI auth data to hosts.yml so gh can discover refreshed task credentials, and remove the stale hosts.yaml file after a successful write.

Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
@jasonkeung jasonkeung marked this pull request as ready for review May 21, 2026 19:57
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 21, 2026

@jasonkeung

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR updates artifact upload action error formatting so failures with nested causes surface the actionable root cause, and adds unit coverage for quota-limit and single-layer error cases. I did not find correctness or security issues in the changed Rust logic itself, and there is no approved spec context to validate against.

Concerns

  • The change affects user-visible error copy/behavior, but the PR description only says screenshots/videos are not applicable. Per the repo review guidance, please attach a screenshot or short recording demonstrating the failed artifact upload path end to end, showing that the quota-limit root cause is surfaced.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

jasonkeung and others added 2 commits May 21, 2026 16:02
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
@jasonkeung jasonkeung requested review from bnavetta and removed request for bnavetta May 26, 2026 15:55
@jasonkeung jasonkeung requested a review from bnavetta May 27, 2026 18:33
Comment thread app/src/ai/blocklist/action_model/execute/upload_artifact.rs Outdated
Co-Authored-By: Oz <oz-agent@warp.dev>
@jasonkeung jasonkeung enabled auto-merge (squash) May 28, 2026 15:49
@jasonkeung jasonkeung merged commit f6bf91c into master May 28, 2026
25 checks passed
@jasonkeung jasonkeung deleted the oz-agent/artifact-upload-error-surfacing branch May 28, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants