REMOTE-1727 Surface artifact upload root cause#11386
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Write GitHub CLI auth data to hosts.yml so gh can discover refreshed task credentials, and remove the stale hosts.yaml file after a successful write. Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates artifact upload action error formatting so failures with nested causes surface the actionable root cause, and adds unit coverage for quota-limit and single-layer error cases. I did not find correctness or security issues in the changed Rust logic itself, and there is no approved spec context to validate against.
Concerns
- The change affects user-visible error copy/behavior, but the PR description only says screenshots/videos are not applicable. Per the repo review guidance, please attach a screenshot or short recording demonstrating the failed artifact upload path end to end, showing that the quota-limit root cause is surfaced.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
…ifact-upload-error-surfacing
Co-Authored-By: Oz <oz-agent@warp.dev>
Description
Preserves the actionable root cause when an artifact upload target request fails, so quota failures surface as an artifact upload limit message instead of only
Failed to create file artifact upload target.https://www.loom.com/share/2c05a308b87a42b981ea037234aca463

Linked Issue
REMOTE-1727
ready-to-specorready-to-implement.Testing
cargo fmt --manifest-path /workspace/warp/Cargo.toml --all -- --checkcargo test --manifest-path /workspace/warp/Cargo.toml -p warp format_upload_artifact_errorI have manually tested my changes locally with
./script/runScreenshots / Videos
Not applicable for this focused error-copy change.
Agent Mode
CHANGELOG-BUG-FIX: Artifact upload failures now surface actionable quota-limit details when upload limits are reached.
Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/aa254ad4-a7ab-49b0-95d6-5af18280c54b
Run: https://oz.staging.warp.dev/runs/019e42ff-b61e-73ae-b998-29f13642cd6d
Plans:
This PR was generated with Oz.