Skip to content

Fix arity of request_ambient_agent_task_id_for_hidden_child test call#11483

Merged
jefflloyd merged 1 commit into
masterfrom
jlloyd/fix-request-ambient-agent-task-id-arity
May 21, 2026
Merged

Fix arity of request_ambient_agent_task_id_for_hidden_child test call#11483
jefflloyd merged 1 commit into
masterfrom
jlloyd/fix-request-ambient-agent-task-id-arity

Conversation

@jefflloyd
Copy link
Copy Markdown
Contributor

Description

Fix a pre-existing compile error in app/src/pane_group/mod_tests.rs that breaks every Warp CI job that builds the warp test binary (Formatting + Clippy (MacOS / Linux / Windows) and the Run *Tests jobs).

The call site in test_entering_remote_parent_agent_view_lazily_restores_local_hidden_child_pane was passing 4 arguments to request_ambient_agent_task_id_for_hidden_child, but the helper at app/src/pane_group/mod_tests.rs:574 only takes 3 (panes, child_pane_id, ctx). The stray local_child_conversation_id argument was added in #10794 and isn't part of the signature, so rustc rejects it with E0061. The two other in-tree call sites already use the correct 3-arg shape.

This is currently masking CI on every open PR that triggers Warp CI (e.g. #11479's dependabot/cargo/openssl-0.10.80). The fix is the exact removal rustc itself suggests.

Diagnosis context: conversation, plan.

Linked Issue

None — this is a bare compile-fix for a regression in test code introduced by #10794.

Testing

Validated locally in a worktree off origin/master:

  • cargo fmt --all -- --check — clean.
  • cargo check -p warp --tests — succeeds (previously failed with E0061).
  • cargo clippy --locked -p warp --tests --all-targets -- -D warnings — succeeds.

(Workspace-wide clippy hit an unrelated local command-signatures-v2 build-script error tied to a corepack/yarn mismatch in my environment, not introduced by this change; CI will exercise the full workspace.)

  • I have manually tested my changes locally with cargo check/cargo clippy (no runtime behavior changes — this is a test-only call-site fix).

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Co-Authored-By: Oz oz-agent@warp.dev

The call site in test_entering_remote_parent_agent_view_lazily_restores_local_hidden_child_pane
was passing 4 arguments to request_ambient_agent_task_id_for_hidden_child, which only takes 3
(panes, child_pane_id, ctx). The extra `local_child_conversation_id` argument was introduced in
#10794 and is not part of the helper's signature, so the warp test binary fails to compile on
all platforms.

Drop the stray argument so the call matches the helper definition.

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label May 21, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 21, 2026

@jefflloyd

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@jefflloyd jefflloyd requested a review from kjankov May 21, 2026 15:57
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR removes an extra argument from a test helper call in app/src/pane_group/mod_tests.rs, matching the helper's three-argument signature and restoring test-binary compilation.

Concerns

  • No blocking correctness, spec-alignment, or security concerns found in the changed line.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@jefflloyd jefflloyd merged commit 647bbb9 into master May 21, 2026
32 checks passed
@jefflloyd jefflloyd deleted the jlloyd/fix-request-ambient-agent-task-id-arity branch May 21, 2026 17:18
Stoica-Mihai pushed a commit to Stoica-Mihai/warp that referenced this pull request Jun 5, 2026
…warpdotdev#11483)

## Description
Fix a pre-existing compile error in `app/src/pane_group/mod_tests.rs`
that breaks every Warp CI job that builds the `warp` test binary
(`Formatting + Clippy (MacOS / Linux / Windows)` and the `Run *Tests`
jobs).

The call site in
`test_entering_remote_parent_agent_view_lazily_restores_local_hidden_child_pane`
was passing 4 arguments to
`request_ambient_agent_task_id_for_hidden_child`, but the helper at
`app/src/pane_group/mod_tests.rs:574` only takes 3 (`panes`,
`child_pane_id`, `ctx`). The stray `local_child_conversation_id`
argument was added in warpdotdev#10794 and isn't part of the signature, so `rustc`
rejects it with E0061. The two other in-tree call sites already use the
correct 3-arg shape.

This is currently masking CI on every open PR that triggers Warp CI
(e.g. warpdotdev#11479's `dependabot/cargo/openssl-0.10.80`). The fix is the exact
removal `rustc` itself suggests.

Diagnosis context:
[conversation](https://staging.warp.dev/conversation/7e6b9f40-55c9-4235-bc3c-1a5424213cc4),
[plan](https://staging.warp.dev/drive/notebook/kmgJ7rLA29QP3bvmIzBNS6).

## Linked Issue
None — this is a bare compile-fix for a regression in test code
introduced by warpdotdev#10794.

## Testing
Validated locally in a worktree off `origin/master`:
- `cargo fmt --all -- --check` — clean.
- `cargo check -p warp --tests` — succeeds (previously failed with
E0061).
- `cargo clippy --locked -p warp --tests --all-targets -- -D warnings` —
succeeds.

(Workspace-wide clippy hit an unrelated local `command-signatures-v2`
build-script error tied to a `corepack`/`yarn` mismatch in my
environment, not introduced by this change; CI will exercise the full
workspace.)

- [x] I have manually tested my changes locally with `cargo
check`/`cargo clippy` (no runtime behavior changes — this is a test-only
call-site fix).

## Agent Mode
- [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode

<!--
CHANGELOG-NONE
-->

Co-Authored-By: Oz <oz-agent@warp.dev>

Co-authored-by: Oz <oz-agent@warp.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants