UI Polish orchestration pill bar +segmented control to match Figma#11578
UI Polish orchestration pill bar +segmented control to match Figma#11578advait-m wants to merge 2 commits into
Conversation
Polish pill bar and Cloud/Local segmented control to match Figma: - Pill metrics (gap, padding, radius, content gap, label max width). - Theme-token colors for rest/hover/selected and divider. - Pin/dots icon sizing and offsets; divider visibility rules. - Segmented control height/font to match picker style. - Static confirmation-card pills are unaffected. Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR polishes the orchestration pill bar metrics, colors, icon sizing, and the Cloud/Local segmented control. The description includes a Loom recording, so the user-facing visual evidence requirement is satisfied.
Concerns
- The overflow-button label reserve no longer matches the new pill right padding and button offset, so the hover dots can cover the trailing edge of pill labels.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| const OVERFLOW_BUTTON_SIZE: f32 = PILL_ICON_BUTTON_SIZE; | ||
| /// Label slot width reserved for the hover-only overflow button. The button | ||
| /// sits 4px into the right padding, so it overlaps 12px of the label slot. | ||
| const OVERFLOW_BUTTON_LABEL_RESERVE: f32 = OVERFLOW_BUTTON_SIZE - 4.; |
There was a problem hiding this comment.
Loom: https://www.loom.com/share/545436e86429499dafe66d4e7efa9237
Fixes https://linear.app/warpdotdev/issue/QUALITY-755/ui-polish-pass
Slack thread: https://warpdev.slack.com/archives/C09769R5GBT/p1779293593411769
Description
Polishes the orchestration pill bar and the Cloud/Local segmented control to match the Figma spec.
UI changes:
fg_overlay_2at rest,fg_overlay_3on hover,foreground/backgroundwhen selected (no hardcoded colors so theming keeps working).fg_overlay_6; vertical divider between pinned + unpinned sections usesfg_overlay_3and only renders when there are unpinned pills.STATIC_PILL_*), so this PR does not touch their geometry.Figma references:
4061:215684073:19868Testing
cargo fmt --checkclean.cargo clippy --workspace --all-targets --all-features --tests -- -D warningsclean.cargo check -p warpclean post-merge withmaster.