Skip to content

UI Polish orchestration pill bar +segmented control to match Figma#11578

Open
advait-m wants to merge 2 commits into
masterfrom
advait/orchestration-pill-ui-polish
Open

UI Polish orchestration pill bar +segmented control to match Figma#11578
advait-m wants to merge 2 commits into
masterfrom
advait/orchestration-pill-ui-polish

Conversation

@advait-m
Copy link
Copy Markdown
Member

@advait-m advait-m commented May 22, 2026

Loom: https://www.loom.com/share/545436e86429499dafe66d4e7efa9237
Fixes https://linear.app/warpdotdev/issue/QUALITY-755/ui-polish-pass
Slack thread: https://warpdev.slack.com/archives/C09769R5GBT/p1779293593411769

Description

Polishes the orchestration pill bar and the Cloud/Local segmented control to match the Figma spec.

UI changes:

  • Pill metrics: 22px height, 20px corner radius, 8px row gap, 4px/6px horizontal padding, 2px content gap (4px when hovered + selected), 83px label max-width.
  • Theme-token backgrounds: fg_overlay_2 at rest, fg_overlay_3 on hover, foreground/background when selected (no hardcoded colors so theming keeps working).
  • Inactive pill label uses fg_overlay_6; vertical divider between pinned + unpinned sections uses fg_overlay_3 and only renders when there are unpinned pills.
  • Pin and overflow (3-dot) icons normalized to 12px inside a 16/20px hit slot, with the overflow button offset 4px from the trailing edge per Figma.
  • Static (non-interactive) confirmation-card agent pills kept on a separate set of constants (STATIC_PILL_*), so this PR does not touch their geometry.
  • Cloud/Local segmented control: 36px height, 14px label, 4px padding — matches the orchestration dropdown pickers.

Figma references:

  • Component variants: 4061:21568
  • Full pill bar row: 4073:19868

Testing

  • cargo fmt --check clean.
  • cargo clippy --workspace --all-targets --all-features --tests -- -D warnings clean.
  • cargo check -p warp clean post-merge with master.
  • Manual verification recommended for the orchestrator pill's new aggregated in-progress state (introduced by Show orchestrator pill as in-progress while children run #11367, now composed with this PR's polish) and for hover/selected transitions.

advait-m and others added 2 commits May 22, 2026 14:41
Polish pill bar and Cloud/Local segmented control to match Figma:
- Pill metrics (gap, padding, radius, content gap, label max width).
- Theme-token colors for rest/hover/selected and divider.
- Pin/dots icon sizing and offsets; divider visibility rules.
- Segmented control height/font to match picker style.
- Static confirmation-card pills are unaffected.

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label May 22, 2026
@advait-m advait-m changed the title Polish orchestration pill bar + Cloud/Local segmented control to match Figma UI Polish orchestration pill bar + Cloud/Local segmented control to match Figma May 22, 2026
@advait-m advait-m changed the title UI Polish orchestration pill bar + Cloud/Local segmented control to match Figma UI Polish orchestration pill bar +segmented control to match Figma May 22, 2026
@advait-m advait-m marked this pull request as ready for review May 23, 2026 00:30
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 23, 2026

@advait-m

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR polishes the orchestration pill bar metrics, colors, icon sizing, and the Cloud/Local segmented control. The description includes a Loom recording, so the user-facing visual evidence requirement is satisfied.

Concerns

  • The overflow-button label reserve no longer matches the new pill right padding and button offset, so the hover dots can cover the trailing edge of pill labels.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

const OVERFLOW_BUTTON_SIZE: f32 = PILL_ICON_BUTTON_SIZE;
/// Label slot width reserved for the hover-only overflow button. The button
/// sits 4px into the right padding, so it overlaps 12px of the label slot.
const OVERFLOW_BUTTON_LABEL_RESERVE: f32 = OVERFLOW_BUTTON_SIZE - 4.;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] The overflow button now sits 4px from the trailing edge with only 6px of right padding, so it overlaps 14px of the label slot while this reserve still clips only 12px. Increase the reserve or derive it from the padding/offset constants so hover dots cannot cover the last label glyphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant