Skip to content

fix: sanitize minidump breadcrumbs for bincode#11602

Open
GodWhiteK wants to merge 1 commit into
warpdotdev:masterfrom
GodWhiteK:fix-minidump-breadcrumb-bincode
Open

fix: sanitize minidump breadcrumbs for bincode#11602
GodWhiteK wants to merge 1 commit into
warpdotdev:masterfrom
GodWhiteK:fix-minidump-breadcrumb-bincode

Conversation

@GodWhiteK
Copy link
Copy Markdown

@GodWhiteK GodWhiteK commented May 23, 2026

Description

This PR avoids sending the full sentry::Breadcrumb through the minidump server IPC channel. sentry::Breadcrumb can contain arbitrary JSON data, which does not round-trip through bincode and can produce deserialization errors in the minidump server.

Instead, the IPC command now sends a small MinidumpBreadcrumb payload containing the same fields forwarded by the native reporters: type, category, level, and message. The minidump server reconstructs a Sentry breadcrumb from that payload.

A regression test covers a breadcrumb with nested JSON data and verifies that the minidump command round-trips through bincode.

Linked Issue

Closes #5711

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below.

Testing

  • Added minidump_breadcrumb_command_round_trips_through_bincode
  • Ran git diff --cached --check
  • I have manually tested my changes locally with ./script/run

I could not run the Rust test locally because this Windows environment does not currently have cargo / rustup / rustfmt available on PATH.

Screenshots / Videos

Not applicable; this is crash reporting IPC behavior.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Fixed minidump crash reporting breadcrumb serialization when breadcrumbs contain arbitrary JSON data.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 23, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @GodWhiteK on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 23, 2026

@GodWhiteK

This PR is not linked to an issue that is marked with ready-to-implement.

Issue-state enforcement details:

To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 23, 2026
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GodWhiteK

This PR is not linked to an issue that is marked with ready-to-implement.

Issue-state enforcement details:

  • Associated same-repo issues checked: none

  • Required readiness label: ready-to-implement

To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.

Powered by Oz

@GodWhiteK
Copy link
Copy Markdown
Author

@cla-bot check

1 similar comment
@GodWhiteK
Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label May 23, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 23, 2026

The cla-bot has been summoned, and re-checked this pull request!

@GodWhiteK
Copy link
Copy Markdown
Author

/oz-review

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GodWhiteK

This PR is not linked to an issue that is marked with ready-to-implement.

Issue-state enforcement details:

  • Associated same-repo issues checked: #5711

  • Required readiness label: ready-to-implement

To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.

Powered by Oz

@GodWhiteK
Copy link
Copy Markdown
Author

Linked this PR to #5711 in the description. #5711 is open, has the ready-to-implement label, and GitHub shows this PR in the issue's Development section.

I also ran /oz-review, but Oz still requested changes while reporting that it checked #5711. Could @oss-maintainers take a look at the issue-state enforcement result or re-run/dismiss it? CI is also still awaiting maintainer approval for this external-contributor PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warp not starting on Windows

1 participant