fix: sanitize minidump breadcrumbs for bincode#11602
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @GodWhiteK on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
This PR is not linked to an issue that is marked with Issue-state enforcement details:
To continue, link this PR to a same-repo issue such as Powered by Oz |
There was a problem hiding this comment.
This PR is not linked to an issue that is marked with ready-to-implement.
Issue-state enforcement details:
-
Associated same-repo issues checked: none
-
Required readiness label:
ready-to-implement
To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.
Powered by Oz
|
@cla-bot check |
1 similar comment
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
/oz-review |
There was a problem hiding this comment.
This PR is not linked to an issue that is marked with ready-to-implement.
Issue-state enforcement details:
-
Associated same-repo issues checked: #5711
-
Required readiness label:
ready-to-implement
To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.
Powered by Oz
|
Linked this PR to #5711 in the description. #5711 is open, has the I also ran |
Description
This PR avoids sending the full
sentry::Breadcrumbthrough the minidump server IPC channel.sentry::Breadcrumbcan contain arbitrary JSON data, which does not round-trip throughbincodeand can produce deserialization errors in the minidump server.Instead, the IPC command now sends a small
MinidumpBreadcrumbpayload containing the same fields forwarded by the native reporters: type, category, level, and message. The minidump server reconstructs a Sentry breadcrumb from that payload.A regression test covers a breadcrumb with nested JSON data and verifies that the minidump command round-trips through
bincode.Linked Issue
Closes #5711
ready-to-specorready-to-implement.Testing
minidump_breadcrumb_command_round_trips_through_bincodegit diff --cached --check./script/runI could not run the Rust test locally because this Windows environment does not currently have
cargo/rustup/rustfmtavailable on PATH.Screenshots / Videos
Not applicable; this is crash reporting IPC behavior.
Agent Mode
CHANGELOG-BUG-FIX: Fixed minidump crash reporting breadcrumb serialization when breadcrumbs contain arbitrary JSON data.