Add AWS Bedrock region selection support#11639
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: kc4020.
|
|
This PR is not linked to an issue that is marked with Issue-state enforcement details:
Readiness check:
To continue, link this PR to a same-repo issue such as Powered by Oz |
There was a problem hiding this comment.
This PR is not linked to an issue that is marked with ready-to-implement.
Issue-state enforcement details:
-
Associated same-repo issues checked: #8506
-
Required readiness label:
ready-to-implement
Readiness check:
- #8506: missing
ready-to-implement; readiness labels present: none
To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.
Powered by Oz
8506fec to
f5fc944
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @keyuchen21 on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
recheck |
|
@cla-bot check |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @keyuchen21 on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Watching |
|
Hi @keyuchen21 — a reviewer requested changes on this PR and it hasn't had activity from you in 11 days. When you get a chance, please push updates or reply to the review so a reviewer can take another look. Without activity, this PR will be automatically closed after 30 days of inactivity. |
Adds a configurable AWS region setting so users can specify which region to use for Bedrock API requests (e.g. us-east-1, us-west-2). Previously the region field was hardcoded to an empty string. Changes: - Add `aws_bedrock_region` setting to AISettings - Store resolved region in AwsCredentials struct - Capture region from AWS SDK during credential loading - Pass region through to the server API request - Add region input field to Settings > AI > AWS Bedrock UI - Refresh credentials when region setting changes - Display loaded region in credential status card
f5fc944 to
75aa6f9
Compare
|
"the ready-to-implement label on issue #8506" — that requires a Warp maintainer to add. |

Summary
Closes #8506
Adds first-class AWS Bedrock region selection support. Users can now configure their preferred AWS region (e.g.
us-east-1,eu-west-1) directly in Warp's AI settings, enabling Bedrock inference in any supported region.Changes
crates/ai/src/aws_credentials.rs— Addedregionfield toAwsCredentialsstruct, fixed proto conversion (was hardcoding empty string), enhanced status card to display active regioncrates/ai/src/aws_credentials_tests.rs— New test file: 9 unit tests covering region storage, proto conversion, and UI displaycrates/ai/src/api_keys_tests.rs— Added tests for AWS credentials in API key request flowapp/src/settings/ai.rs— Addedaws_bedrock_regionsetting with TOML persistence and cloud syncapp/src/ai/aws_credentials.rs— Updatedload_aws_credentials_from_sdk()to accept region override, resolves from SDK when not set, subscribes to region setting changesapp/src/settings_view/ai_page.rs— Added "AWS Region" text input to the Bedrock settings widgetHow to use
us-east-1,us-west-2,eu-west-1) — if left blank, the region is automatically resolved from your~/.aws/configorAWS_REGIONenvironment variableaws sso login) for credential refreshOnce loaded, the status card shows: "Credentials loaded · Region: us-east-1"
Region resolution priority:
AWS_REGIONorAWS_DEFAULT_REGIONenvironment variable~/.aws/configfor the configured profileTest plan
cargo nextest run -p ai(37 tests)~/.aws/configCHANGELOG-NEW-FEATURE: Added AWS region selection to Bedrock settings for choosing inference region