fix: mute inaccessible run metadata notice#11686
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR preserves the existing fetch-error banner for ordinary run metadata failures while adding structured HTTP-status detection so 401/403 metadata fetch failures render as a muted access notice for shared sessions. The model, details panel, native view, WASM view, and targeted tests were updated consistently.
Concerns
No blocking correctness, security, or spec-alignment concerns found. The PR description includes visual validation for the user-facing notice.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| .finish(); | ||
| content.add_child( | ||
| Container::new(error_banner) | ||
| Container::new(self.render_fetch_error_notice(fetch_error, appearance, app)) |
There was a problem hiding this comment.
i could be completely wrong here but could this affect the spacing for errors that are not the access denied one? by adding extra spacing around empty content
There was a problem hiding this comment.
I don't think so? The content that's rendered outside the if-statement in render_fetch_error_notice matches what we are doing in the removed block above unless I am missing something.
There was a problem hiding this comment.
Yeah it looks the same to me! As long as fetch_error is Some, the content should be non-empty
| .finish(); | ||
| content.add_child( | ||
| Container::new(error_banner) | ||
| Container::new(self.render_fetch_error_notice(fetch_error, appearance, app)) |
There was a problem hiding this comment.
Yeah it looks the same to me! As long as fetch_error is Some, the content should be non-empty
3 participants
Description
Fixes the shared-session details panel state for cloud runs whose metadata fetch returns a forbidden response. Instead of showing the raw API error in a red alert, the panel now renders a muted info notice explaining that the shared session can be viewed, but run metadata is only visible to users with access to that specific run.
Linked Issue
REMOTE-1771
ready-to-specorready-to-implement.Testing
rustfmt --check /workspace/warp/app/src/ai/conversation_details_panel.rs /workspace/warp/app/src/ai/conversation_details_panel_tests.rscargo test --manifest-path /workspace/warp/Cargo.toml -p warp test_metadata_access_denied_fetch_error_detection --libI have manually tested my changes locally with
./script/runScreenshots / Videos
Agent Mode
CHANGELOG-BUG-FIX: Shared cloud-agent session details now show a muted no-access notice when run metadata is restricted instead of displaying a raw permission error.
Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/371d26d9-57fb-4b92-855e-bdef55efeebe
Run: https://oz.staging.warp.dev/runs/019e64cc-9d78-7c77-a53e-af0f869b53fe
This PR was generated with Oz.