Force-enable fast-forward chip in cloud agent conversations#11690
Merged
harryalbert merged 4 commits intoMay 27, 2026
Merged
Conversation
harryalbert
force-pushed
the
harry/lock-fast-forward-chip-in-cloud-agent-conversations
branch
from
521af54 to
7ec60c0
Compare
harryalbert
changed the title
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR force-renders the fast-forward/auto-approve chip as enabled and locked for cloud agent contexts in both the warping indicator and agent input footer, with a no-op toggle path and explanatory tooltip.
Concerns
- No blocking concerns found in the annotated diff.
- Security pass: no security findings.
- Spec alignment: no approved spec context was available for this PR.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
bnavetta
approved these changes
May 27, 2026
When viewing an ambient (cloud) agent conversation, the fast forward chip both in the warping line and in the agent view footer was effectively a no-op: it never reflected an action that mattered, but it still toggled the underlying state. This makes that meaningless toggle explicit: - The fast forward chip in both the warping line and the agent input footer is rendered in an always-on state when the pane is in a cloud-agent conversation (CloudAgent / ThirdPartyCloudAgent origin, the conversation transcript viewer, or a dummy cloud-mode pane). - The chip is not given disabled styling — it still looks active. - Clicks on the chip and the fast-forward keybinding are both no-ops in these contexts. The action handler short-circuits in TerminalView::ToggleAutoexecuteMode, and the warping-line chip itself skips dispatching the action. - The chip tooltip changes to "Fast forward is always enabled for cloud agent conversations". For the warping-line chip we also hide the keybinding label since the binding is locked too. The locked state is computed via the existing is_in_cloud_context helper, which already covers cloud-mode panes, transcript viewers, and third-party cloud agents. Co-Authored-By: Oz <oz-agent@warp.dev>
harryalbert
force-pushed
the
harry/lock-fast-forward-chip-in-cloud-agent-conversations
branch
from
7ec60c0 to
dd43916
Compare
harryalbert
deleted the
harry/lock-fast-forward-chip-in-cloud-agent-conversations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fast forward is always enabled for cloud agent conversations (cloud agents can't really wait for approval to write diffs, perform actions, etc), but we don't make this clear anywhere in the UI. To fix this, we can force-enable the fast forward chip (both in the warping indicator line and in the agent view footer) with a tooltip explaining that fast forward is always enabled for cloud mode conversations.
Implements APP-4606.
Testing
https://www.loom.com/share/09c43da23cbb40baadb11fccd9dd164f
Conversation: https://staging.warp.dev/conversation/ffa01502-e840-49ba-88fa-2e1689fb66a4
Run: https://oz.staging.warp.dev/runs/019e64e2-7832-7a5d-8b96-df1ae64ed20a
This PR was generated with Oz.