feat: make /app redirect to cloud agent in wasm#11781
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR rewrites Warp-on-Web /app launches to the Cloud Agent conversation action, skips restoring persisted state for that web-home launch URL, and adds a workspace source that opens a Cloud Agent tab in a fresh window.
Concerns
- The no-primary-window action path now constructs
NewWorkspaceSource::AmbientAgentdirectly, bypassing the existing Cloud Agent add-tab gating; see the inline comment. - For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This reverts commit 9cec860.
captainsafia
left a comment
There was a problem hiding this comment.
Nice! It's awesome that we were able to get this to redirect to the cloud-mode prompt. I didn't see it in your demo but I assume everythign actually works fine with submitting a prompt via this new redirect and then transitioning to the sesion share for that conversation?

Description
Fix
/appin Warp-on-Web so it opens the Cloud Agent start experience instead of a regular Agent tab or restored workspace state.Linked Issue
N/A
Testing
cargo fmt -p warpMACOSX_DEPLOYMENT_TARGET=10.14 cargo test -p warp uri::tests::test_app_web_link_rewrites_to_new_cloud_agent_conversationI have manually tested my changes locally with
./script/runhttps://www.loom.com/share/5c6aa6142e9a43e29519419de771104f
Agent Mode
CHANGELOG-BUG-FIX: Fixed
/appin Warp-on-Web opening the wrong Agent experience instead of the Cloud Agent start page.