Improve UX for the lightbox.#11783
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR tightens lightbox image layout to the rendered image bounds and introduces a lightbox-specific button theme so controls remain styled for the dark scrim regardless of the app theme. The attached screenshot satisfies the repository requirement for visual evidence on this user-facing change.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| ) -> Vector2F { | ||
| let size = constraint.max; | ||
| let mut size = constraint.max; | ||
| // If we want to lay out the image using the |
There was a problem hiding this comment.
argh i thought we fixed this 😭
There was a problem hiding this comment.
oh actually this might have been me getting distracted in the middle of writing a comment 😅
There was a problem hiding this comment.
the old bug would happen when editing existing lines, which isn't the case here, so maybe this is a separate issue?
vorporeal
force-pushed
the
david/improve-lightbox-ux
branch
from
0463db1 to
ec85925
Compare
2 participants
Description
This addresses some UX feedback from Erica:
This fixes the feedback in the following ways:
Imageto utilize the image size when doing layout, to ensure the bounding box for the element is tight to the actual rendered image bounds.Secondarybutton theme when using theDarkapplication theme.Fixes #11785.
Screenshot
Testing