Hide queued prompts panel while an inline menu is open#11848
Merged
Conversation
harryalbert
force-pushed
the
oz/hide-queued-prompts-when-inline-menu-open
branch
from
979e024 to
54ee355
Compare
The queued prompts panel and the inline input menus (slash commands, model/profile selector, prompts, conversation, skill, user query, rewind, history, repos, plan) were both rendered into the same agent input column, so they could appear simultaneously. Guard the panel's render in `render_agent_input` with `!suggestions_mode_model.is_inline_menu_open()` so the panel is not rendered at all (rather than collapsed) whenever any inline menu is open. Co-Authored-By: Oz <oz-agent@warp.dev>
harryalbert
force-pushed
the
oz/hide-queued-prompts-when-inline-menu-open
branch
from
54ee355 to
c705495
Compare
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR passes the input suggestions-mode model to QueuedPromptsPanelView and hides the queued prompts panel while an inline menu is open. I reviewed the changed render path, model subscriptions, queue event handling, and security surface.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
advait-m
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@peterrajani pointed out that it looks kind of funky when both an inline menu and queued prompts menu are open at the same time. When an inline menu is open we can just auto-hide the queued prompts menu.
Addresses APP-4623
Testing
./script/runDemo
https://www.loom.com/share/0035bef74b29400eb33f7bbdebf4a98e
Agent Mode
Conversation: https://staging.warp.dev/conversation/7f318ff5-49ae-48d3-b6bc-0d03af4020b3
Run: https://oz.staging.warp.dev/runs/019e6fe9-33a7-7d27-be90-e51cd07f68f9
This PR was generated with Oz.