Fix empty RPROMPT handling in zsh.#11868
Merged
Merged
Conversation
alokedesai
approved these changes
May 29, 2026
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR adjusts zsh bootstrap handling so Warp prompt mode no longer synthesizes an empty RPROMPT, and adds zsh integration coverage for the unset right-prompt behavior.
Concerns
- For this user-facing terminal rendering change, please include screenshots or a short screen recording demonstrating the wrapped zsh command behavior working end to end. The PR description currently says screenshots/videos are not attached and manual end-to-end reproduction is pending.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
329bb6f to
de69fb9
Compare
de69fb9 to
0865c78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes a zsh-specific issue where long commands could gain a duplicated leading character in finished command blocks after wrapping while using Warp's prompt.
When Warp hides a user-defined right prompt, the zsh bootstrap was recreating
RPROMPTas an empty zero-width prompt. Although it rendered no visible content, zsh still performed right-prompt layout and redraw behavior, which could corrupt the captured command grid. This change leavesRPROMPTunset in Warp prompt mode, while preserving handling for real non-empty right prompts, and adds regression coverage for that behavior.Linked Issue
N/A
Testing
cargo fmt --all --manifest-path Cargo.toml --checkgit diff --checkcargo check --manifest-path Cargo.toml -p integrationcargo nextest run --manifest-path Cargo.toml --no-fail-fast -p integration -E 'test(test_warp_prompt_unsets_zsh_rprompt)'./script/run.Screenshots / Videos
Not attached; manual end-to-end reproduction verification is pending.
Agent Mode
Changelog Entries for Stable
CHANGELOG-BUG-FIX: Fixed duplicated leading characters in wrapped zsh command blocks when using the Warp prompt.
Co-Authored-By: Oz oz-agent@warp.dev