Extract agent identity public API request from BaseClient#11979
Draft
vorporeal wants to merge 15 commits into
Draft
Extract agent identity public API request from BaseClient#11979vorporeal wants to merge 15 commits into
vorporeal wants to merge 15 commits into
Conversation
Move the remaining auth-client public GET across the crate boundary while keeping ambient headers and app event reactions app-owned. Co-Authored-By: Oz <oz-agent@warp.dev>
3134fc6 to
0436dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AuthClientImpl::list_agent_identities()from the remaining endpoint-shapedBaseClientshim into an authenticated public GET helper owned bywarp_server_client.AuthClientand associated logic to thewarp_server_clientcrate. #11977; it does not migrate unrelated AI or harness endpoints.Testing
./script/formatcargo check --manifest-path /Users/david/src/warp-auth-public-api-helper/Cargo.toml -p warp_server_client -p warpcargo nextest run --manifest-path /Users/david/src/warp-auth-public-api-helper/Cargo.toml -p warp_server_clientcargo check --manifest-path /Users/david/src/warp-auth-public-api-helper/Cargo.toml --target wasm32-unknown-unknown -p warp_server_clientcargo clippy --manifest-path /Users/david/src/warp-auth-public-api-helper/Cargo.toml -p warp_server_client -p warp --all-targets --tests -- -D warningscargo clippy --manifest-path /Users/david/src/warp-auth-public-api-helper/Cargo.toml --workspace --all-targets --all-features --tests -- -D warnings; it is blocked in this environment becausecommand-signatures-v2requires Node (env: node: No such file or directory).Agent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/5eda2cd5-6a44-41a7-9810-2c73b800c0ee
Run: https://oz.staging.warp.dev/runs/019e8064-0bac-7a79-bc93-58e35969a5b4
This PR was generated with Oz.