Skip to content

Promote orchestration viewer streamer#12042

Merged
cephalonaut merged 1 commit into
masterfrom
matthew/enable-orchestration-viewer-streamer
Jun 2, 2026
Merged

Promote orchestration viewer streamer#12042
cephalonaut merged 1 commit into
masterfrom
matthew/enable-orchestration-viewer-streamer

Conversation

@cephalonaut
Copy link
Copy Markdown
Contributor

Description

Promotes orchestration_viewer_streamer from Dogfood-only to enabled in default Warp client builds by:

  • adding the Cargo feature to the default feature set
  • bridging the Cargo feature to FeatureFlag::OrchestrationViewerStreamer at runtime
  • removing the flag from DOGFOOD_FLAGS now that it is enabled by default

Testing

  • ./script/format
  • cargo clippy --workspace --all-targets --all-features --tests -- -D warnings

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Conversation: https://staging.warp.dev/conversation/cc96ebef-b124-42c7-a914-80978c5738a3
Run: https://oz.staging.warp.dev/runs/019e84be-4a3f-7a85-9423-55e19eafdd43
This PR was generated with Oz.

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jun 2, 2026
@cephalonaut cephalonaut requested a review from szgupta June 2, 2026 18:02
@cephalonaut cephalonaut marked this pull request as ready for review June 2, 2026 18:03
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Jun 2, 2026

@cephalonaut

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR promotes orchestration_viewer_streamer to the default Warp client feature set, bridges it to FeatureFlag::OrchestrationViewerStreamer, and removes the dogfood-only runtime enablement.

Concerns

  • The promoted streamer path changes user-visible orchestration viewer behavior, but the PR description does not include screenshots or a screen recording demonstrating the behavior end to end.
  • Security review found no diff-backed security concerns.
  • No approved spec context was provided, so there are no spec commitments to compare against.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment thread app/Cargo.toml
"orchestration_v2",
"orchestration_pill_bar",
"orchestration_viewer_pill_bar",
"orchestration_viewer_streamer",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This promotes a user-facing orchestration viewer behavior to default builds, so please include screenshots or a screen recording demonstrating it working end to end.

@cephalonaut cephalonaut merged commit c74d16e into master Jun 2, 2026
43 checks passed
@cephalonaut cephalonaut deleted the matthew/enable-orchestration-viewer-streamer branch June 2, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants