Skip to content

Adjust pill bar scrollbar to prevent overlap with agent chips#12045

Merged
advait-m merged 3 commits into
masterfrom
advait/quality-743-pill-bar-scrollbar-overlap
Jun 2, 2026
Merged

Adjust pill bar scrollbar to prevent overlap with agent chips#12045
advait-m merged 3 commits into
masterfrom
advait/quality-743-pill-bar-scrollbar-overlap

Conversation

@advait-m
Copy link
Copy Markdown
Member

@advait-m advait-m commented Jun 2, 2026

Add margin to avoid overlap for scrollbar with orchestration pill bar - from Slack feedback.

Before:
image

After:
image

Description

The orchestration pill bar's overlaid horizontal scrollbar paints along the bottom edge of the scrollable's content, so it sliced across the bottom of the agent chips/pills. Outer container padding can't fix this because it lives outside the scrollbar's track.

Fix: reserve a small bottom gutter inside the scrollable (below the pill row) so the scrollbar lands just below the pills instead of across them, and trim the outer bottom padding so the bar stays compact (net +4px height). Also pulled the magic 4. scrollbar width into a named const so the gutter↔scrollbar relationship is documented.

All in app/src/ai/blocklist/agent_view/orchestration_pill_bar.rs. The breadcrumb scrollable is intentionally left alone (its existing comment notes the scrollbar-over-labels trade-off was already accepted).

Linked Issue

https://linear.app/warpdotdev/issue/QUALITY-743/adjust-scrollbar-to-prevent-overlap-with-agent-chips

  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

Compiles cleanly (cargo fmt + cargo check -p warp --lib). Visual-only change to vertical spacing of the orchestration pill bar.

  • I have manually tested my changes locally with ./script/run

CHANGELOG-BUG-FIX: Fixed the orchestration pill bar's scrollbar overlapping the agent chips.

Co-Authored-By: Oz oz-agent@warp.dev

The orchestration pill bar's overlaid horizontal scrollbar paints along
the bottom edge of the scrollable's content, so it sliced across the
bottom of the agent pills. Outer container padding can't fix this since
it sits outside the scrollbar's track.

Reserve a small bottom gutter inside the scrollable (below the pill row)
so the scrollbar lands just below the pills, and trim the outer bottom
padding to keep the bar compact (net +4px height).

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jun 2, 2026
@advait-m advait-m marked this pull request as ready for review June 2, 2026 01:54
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Jun 2, 2026

@advait-m

I'm starting a first review of this pull request.

You can follow along in the session on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adjusts the orchestration pill bar layout by reserving an internal bottom gutter for the overlaid horizontal scrollbar, replacing the hard-coded scrollbar thickness with named constants, and trimming the outer bottom padding to keep the bar compact. The attached before/after screenshots satisfy the repo's visual-evidence requirement for this UI change.

Concerns

  • No blocking correctness, security, or spec-drift concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@advait-m advait-m requested a review from cephalonaut June 2, 2026 06:30
@cephalonaut
Copy link
Copy Markdown
Contributor

This is great! If I were really nit picking, I might ask for a pixel of space between the pills and the scrollbar itself if not too much trouble.

@advait-m
Copy link
Copy Markdown
Member Author

advait-m commented Jun 2, 2026

This is great! If I were really nit picking, I might ask for a pixel of space between the pills and the scrollbar itself if not too much trouble.

will do!

@advait-m
Copy link
Copy Markdown
Member Author

advait-m commented Jun 2, 2026

added

image

@advait-m advait-m enabled auto-merge (squash) June 2, 2026 19:59
@advait-m advait-m changed the title [QUALITY-743] Adjust pill bar scrollbar to prevent overlap with agent chips Adjust pill bar scrollbar to prevent overlap with agent chips Jun 2, 2026
@advait-m advait-m merged commit 67569a7 into master Jun 2, 2026
25 checks passed
@advait-m advait-m deleted the advait/quality-743-pill-bar-scrollbar-overlap branch June 2, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants