Adjust pill bar scrollbar to prevent overlap with agent chips#12045
Conversation
The orchestration pill bar's overlaid horizontal scrollbar paints along the bottom edge of the scrollable's content, so it sliced across the bottom of the agent pills. Outer container padding can't fix this since it sits outside the scrollbar's track. Reserve a small bottom gutter inside the scrollable (below the pill row) so the scrollbar lands just below the pills, and trim the outer bottom padding to keep the bar compact (net +4px height). Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adjusts the orchestration pill bar layout by reserving an internal bottom gutter for the overlaid horizontal scrollbar, replacing the hard-coded scrollbar thickness with named constants, and trimming the outer bottom padding to keep the bar compact. The attached before/after screenshots satisfy the repo's visual-evidence requirement for this UI change.
Concerns
- No blocking correctness, security, or spec-drift concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
This is great! If I were really nit picking, I might ask for a pixel of space between the pills and the scrollbar itself if not too much trouble. |
will do! |

Add margin to avoid overlap for scrollbar with orchestration pill bar - from Slack feedback.
Before:

After:

Description
The orchestration pill bar's overlaid horizontal scrollbar paints along the bottom edge of the scrollable's content, so it sliced across the bottom of the agent chips/pills. Outer container padding can't fix this because it lives outside the scrollbar's track.
Fix: reserve a small bottom gutter inside the scrollable (below the pill row) so the scrollbar lands just below the pills instead of across them, and trim the outer bottom padding so the bar stays compact (net +4px height). Also pulled the magic
4.scrollbar width into a named const so the gutter↔scrollbar relationship is documented.All in
app/src/ai/blocklist/agent_view/orchestration_pill_bar.rs. The breadcrumb scrollable is intentionally left alone (its existing comment notes the scrollbar-over-labels trade-off was already accepted).Linked Issue
https://linear.app/warpdotdev/issue/QUALITY-743/adjust-scrollbar-to-prevent-overlap-with-agent-chips
Testing
Compiles cleanly (
cargo fmt+cargo check -p warp --lib). Visual-only change to vertical spacing of the orchestration pill bar../script/runCHANGELOG-BUG-FIX: Fixed the orchestration pill bar's scrollbar overlapping the agent chips.
Co-Authored-By: Oz oz-agent@warp.dev