Fix crash when trying to use the microphone on macOS.#12074
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR switches the macOS microphone permission check from a hand-written Objective-C message send to the typed objc2-av-foundation bindings and wires the new dependency.
Concerns
- For this user-facing crash fix, please include screenshots or a short screen recording demonstrating microphone access working end to end on this branch. The description only states manual testing, and the repo guidance requires visual evidence for behavioral/user-facing changes.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
alokedesai
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
authorizationStatusForMediaTypeAPI returns an unsigned 64-bit integer, but our code was storing the result as ai32. When we moved from using theobjccrate to theobjc2crate, I think the new crate performs more careful checking of these types, and started to produce a runtime error as a result of the type mismatch.The
objc2crate family includesobjc2-av-foundation, which includes concrete APIs for all of the code here. I've moved over to using that, improving safety and clarity.Testing
masterbut succeeds on this branch.