Fix generic string object update dependencies by evelyn-with-warp · Pull Request #12082 · warpdotdev/warp

evelyn-with-warp · 2026-06-02T18:46:04Z

Description

Fixes a sync queue dependency gap where several generic string object update variants did not wait for earlier create/update queue items for the same object.

When a local generic string object was created and then updated before the create response mapped its client ID to a server UID, the update could race ahead and call UpdateGenericStringObject with a UID the server could not find. That matches the observed GraphQL error:

graphql response for Some("UpdateGenericStringObject") had errors ... "Not found: Object UID not found"

This change routes all generic string object update variants through get_update_dependencies, including AIFact, MCPServer, AIExecutionProfile, and TemplatableMCPServer.

Linked Issue

Slack thread: feedback-app 1780425090.994989

The linked issue is labeled ready-to-spec or ready-to-implement.
Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

cargo test --manifest-path /workspace/warp/Cargo.toml -p warp test_sync_queue_generic_string_object_update_depends_on_pending_create
cargo test --manifest-path /workspace/warp/Cargo.toml -p warp sync_queue_dependency
git -C /workspace/warp --no-pager diff --check
cargo fmt --manifest-path /workspace/warp/app/Cargo.toml -- --check
I have manually tested my changes locally with ./script/run

Agent Mode

Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Ensure all generic string object update queue items depend on prior create/update operations for the same object so updates cannot race ahead before a client ID is mapped to a server UID. Co-Authored-By: Oz <oz-agent@warp.dev>

seemeroland

lgtm! As a nit, remove the bug fix changelog

oz-for-oss · 2026-06-02T21:11:48Z

@evelyn-with-warp

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR routes additional generic string object update variants through sync queue update dependencies and adds coverage for an AIFact create/update dependency chain.

Concerns

Queued generic string object updates can now wait behind earlier updates, but their stored revisions are not refreshed after the earlier update succeeds, so a second queued update can still be sent with a stale revision.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Replace the no-dependency catch-all in add_inferred_dependencies with explicit queue item variants so future QueueItem additions must make an intentional dependency decision. Co-Authored-By: Oz <oz-agent@warp.dev>

Update queued generic string object revisions after create/update successes so chained dependent updates use the latest revision before dequeuing. Co-Authored-By: Oz <oz-agent@warp.dev>

evelyn-with-warp · 2026-06-02T21:53:09Z

/oz-review

oz-for-oss · 2026-06-02T21:53:23Z

@evelyn-with-warp

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR makes generic string object update variants participate in sync queue update dependencies and propagates successful revisions to queued updates. The single-create path is covered by the new test.

Concerns

Bulk generic string object creates still share one queue item dependency for all objects in the batch; routing the newly added update variants through get_update_dependencies can unblock updates for later batch objects after the first create success is processed, before those later client IDs have been mapped.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-06-02T21:56:51Z

+            | QueueItem::UpdateAIFact { id, .. }
+            | QueueItem::UpdateMCPServer { id, .. }
+            | QueueItem::UpdateAIExecutionProfile { id, .. }
+            | QueueItem::UpdateTemplatableMCPServer { id, .. }


⚠️ [IMPORTANT] These variants can now depend on BulkCreateGenericStringObjects, but bulk create success reuses one queue item id for the whole batch. handle_dependency_success clears that id after the first created object is processed, so an update for a later object in the same batch can dequeue before its client ID/revision mapping is installed and fail with the same missing-object path this PR is trying to prevent. Please process all bulk create mappings before unblocking/dequeueing dependents, or track bulk dependencies per object.

evelyn-with-warp · 2026-06-02T23:41:37Z

/oz-review

oz-for-oss · 2026-06-02T23:41:49Z

@evelyn-with-warp

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR extends sync queue dependency inference so generic string object update variants wait for prior create/update work on the same object, and it adds per-client dependency tracking for bulk generic string object creates so a bulk queue item can unblock only the matching dependent updates as each object resolves.

Concerns

No blocking correctness, security, or spec-alignment concerns found in the annotated diff. No approved or repository spec context was available for this PR.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Fix generic string object update dependencies

443817e

Ensure all generic string object update queue items depend on prior create/update operations for the same object so updates cannot race ahead before a client ID is mapped to a server UID. Co-Authored-By: Oz <oz-agent@warp.dev>

cla-bot Bot added the cla-signed label Jun 2, 2026

seemeroland approved these changes Jun 2, 2026

View reviewed changes

Comment thread app/src/server/sync_queue.rs Outdated

evelyn-with-warp marked this pull request as ready for review June 2, 2026 21:11

oz-for-oss Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread app/src/server/sync_queue.rs

evelyn-with-warp and others added 2 commits June 2, 2026 21:22

Make sync queue dependencies exhaustive

e4fd4f3

Replace the no-dependency catch-all in add_inferred_dependencies with explicit queue item variants so future QueueItem additions must make an intentional dependency decision. Co-Authored-By: Oz <oz-agent@warp.dev>

Propagate revisions for queued GSO updates

11ce0bc

Update queued generic string object revisions after create/update successes so chained dependent updates use the latest revision before dequeuing. Co-Authored-By: Oz <oz-agent@warp.dev>

oz-for-oss Bot reviewed Jun 2, 2026

View reviewed changes

resolve oz comment

9030fef

oz-for-oss Bot reviewed Jun 2, 2026

View reviewed changes

evelyn-with-warp added 2 commits June 2, 2026 16:57

Merge branch 'master' into oz-agent/fix-gso-update-dependencies

e253ff2

fix ci failure

845f4ef

evelyn-with-warp merged commit 9784123 into master Jun 3, 2026
39 of 41 checks passed

evelyn-with-warp deleted the oz-agent/fix-gso-update-dependencies branch June 3, 2026 00:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix generic string object update dependencies#12082

Fix generic string object update dependencies#12082
evelyn-with-warp merged 6 commits into
masterfrom
oz-agent/fix-gso-update-dependencies

evelyn-with-warp commented Jun 2, 2026 •

edited

Loading

Uh oh!

seemeroland left a comment •

edited

Loading

Uh oh!

Uh oh!

oz-for-oss Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

oz-for-oss Bot left a comment

Uh oh!

Uh oh!

evelyn-with-warp commented Jun 2, 2026

Uh oh!

oz-for-oss Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

oz-for-oss Bot left a comment

Uh oh!

oz-for-oss Bot Jun 2, 2026

Uh oh!

evelyn-with-warp commented Jun 2, 2026

Uh oh!

oz-for-oss Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

oz-for-oss Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

evelyn-with-warp commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked Issue

Testing

Agent Mode

Uh oh!

seemeroland left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oz-for-oss Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

evelyn-with-warp commented Jun 2, 2026

Uh oh!

oz-for-oss Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

evelyn-with-warp commented Jun 2, 2026

Uh oh!

oz-for-oss Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

evelyn-with-warp commented Jun 2, 2026 •

edited

Loading

seemeroland left a comment •

edited

Loading

oz-for-oss Bot commented Jun 2, 2026 •

edited

Loading

oz-for-oss Bot commented Jun 2, 2026 •

edited

Loading

oz-for-oss Bot commented Jun 2, 2026 •

edited

Loading