dogfood nld_classifier_v3#12092
Merged
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR adds the nld_classifier_v3 Cargo feature, wires the new BERT Tiny v3 ONNX model through the input classifier crate and evaluation binary, and updates local/dev bundle scripts to ship v3 while keeping preview on v2 and stable/other channels on v1.
Concerns
- No blocking correctness, security, or spec-alignment issues found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
szgupta
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
for metrics comparison with V2, please checkout the PR https://github.com/warpdotdev/ml_models/pull/10
Linked Issue
ready-to-specorready-to-implement.Testing
./script/runScreenshots / Videos
https://www.loom.com/share/c03060910bf54dc3bfc825948222fe32
improved user experience on this report https://warpdev.slack.com/archives/C08QY6ZBK2A/p1779810034759499;
however, for this one, since
whoopsis a valid cli command, the classifier will still flicker as user typing going onAgent Mode