Skip to content

dogfood nld_classifier_v3#12092

Merged
evelyn-with-warp merged 2 commits into
masterfrom
evelyn/nld-v3
Jun 2, 2026
Merged

dogfood nld_classifier_v3#12092
evelyn-with-warp merged 2 commits into
masterfrom
evelyn/nld-v3

Conversation

@evelyn-with-warp
Copy link
Copy Markdown
Contributor

@evelyn-with-warp evelyn-with-warp commented Jun 2, 2026

Description

  • add nld_classifier_v3, bonded with bert_tiny_v3.onnx
  • let local/dev build subscribe to this feature

for metrics comparison with V2, please checkout the PR https://github.com/warpdotdev/ml_models/pull/10

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

https://www.loom.com/share/c03060910bf54dc3bfc825948222fe32
improved user experience on this report https://warpdev.slack.com/archives/C08QY6ZBK2A/p1779810034759499;
however, for this one, since whoops is a valid cli command, the classifier will still flicker as user typing going on

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label Jun 2, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Jun 2, 2026

@evelyn-with-warp

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds the nld_classifier_v3 Cargo feature, wires the new BERT Tiny v3 ONNX model through the input classifier crate and evaluation binary, and updates local/dev bundle scripts to ship v3 while keeping preview on v2 and stable/other channels on v1.

Concerns

  • No blocking correctness, security, or spec-alignment issues found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@evelyn-with-warp evelyn-with-warp requested a review from szgupta June 2, 2026 22:13
@evelyn-with-warp evelyn-with-warp merged commit 9de6d4d into master Jun 2, 2026
42 checks passed
@evelyn-with-warp evelyn-with-warp deleted the evelyn/nld-v3 branch June 2, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants