Skip to content

Log GraphQL type update errors once per run#12095

Merged
alokedesai merged 1 commit into
masterfrom
oz-agent/graphql-type-errors-once
Jun 3, 2026
Merged

Log GraphQL type update errors once per run#12095
alokedesai merged 1 commit into
masterfrom
oz-agent/graphql-type-errors-once

Conversation

@alokedesai
Copy link
Copy Markdown
Member

Description

Updates the GraphQL client type drift error reports that end with Make sure to update client GraphQL types! to use the ReportErrorLogMode::OncePerRun option introduced by #11971.

This applies to 12 enum-conversion fallback paths across:

  • app/src/server/server_api/ai.rs
  • app/src/workspaces/gql_convert.rs

Each matching report_error! call now passes warp_core::errors::ReportErrorLogMode::OncePerRun, so repeated hits from the same call site are logged only once per app run instead of on every invocation.

Linked Issue

N/A — Slack follow-up.

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • ./script/format

  • ./script/format --check

  • Evidence script: checked 12 Make sure to update client GraphQL types! call sites and confirmed all use warp_core::errors::ReportErrorLogMode::OncePerRun

  • cargo clippy -p warp --all-targets --tests -- -D warnings

  • cargo nextest run -p warp_core -E 'test(report_error_log_mode_controls_log_frequency)' — passed, proving the once-per-run mode logs once across two hits of the same call site

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

N/A — no UI change.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Co-Authored-By: Oz oz-agent@warp.dev

Conversation: https://staging.warp.dev/conversation/b3b97505-1e9f-427c-b87d-7f8757773bd3
Run: https://oz.staging.warp.dev/runs/019e7f0b-9f95-72e6-bb15-5b5b3ad074db

This PR was generated with Oz.

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jun 2, 2026
@alokedesai alokedesai marked this pull request as ready for review June 3, 2026 01:14
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Jun 3, 2026

@alokedesai

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@alokedesai alokedesai enabled auto-merge (squash) June 3, 2026 01:15
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR updates the GraphQL enum-conversion fallback error reports that instruct maintainers to update client GraphQL types so they use ReportErrorLogMode::OncePerRun instead of logging every time a fallback path is hit.

Concerns

  • No blocking concerns found. The changed call sites are internal error-reporting paths, the once-per-run mode is applied consistently to the annotated fallback reports, and the PR is not user-visible.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@alokedesai alokedesai merged commit fe0aee1 into master Jun 3, 2026
43 checks passed
@alokedesai alokedesai deleted the oz-agent/graphql-type-errors-once branch June 3, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants