Log GraphQL type update errors once per run#12095
Merged
Merged
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
ianhodge
approved these changes
Jun 3, 2026
Contributor
There was a problem hiding this comment.
Overview
This PR updates the GraphQL enum-conversion fallback error reports that instruct maintainers to update client GraphQL types so they use ReportErrorLogMode::OncePerRun instead of logging every time a fallback path is hit.
Concerns
- No blocking concerns found. The changed call sites are internal error-reporting paths, the once-per-run mode is applied consistently to the annotated fallback reports, and the PR is not user-visible.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the GraphQL client type drift error reports that end with
Make sure to update client GraphQL types!to use theReportErrorLogMode::OncePerRunoption introduced by #11971.This applies to 12 enum-conversion fallback paths across:
app/src/server/server_api/ai.rsapp/src/workspaces/gql_convert.rsEach matching
report_error!call now passeswarp_core::errors::ReportErrorLogMode::OncePerRun, so repeated hits from the same call site are logged only once per app run instead of on every invocation.Linked Issue
N/A — Slack follow-up.
ready-to-specorready-to-implement.Testing
./script/format./script/format --checkEvidence script: checked 12
Make sure to update client GraphQL types!call sites and confirmed all usewarp_core::errors::ReportErrorLogMode::OncePerRuncargo clippy -p warp --all-targets --tests -- -D warningscargo nextest run -p warp_core -E 'test(report_error_log_mode_controls_log_frequency)'— passed, proving the once-per-run mode logs once across two hits of the same call siteI have manually tested my changes locally with
./script/runScreenshots / Videos
N/A — no UI change.
Agent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/b3b97505-1e9f-427c-b87d-7f8757773bd3
Run: https://oz.staging.warp.dev/runs/019e7f0b-9f95-72e6-bb15-5b5b3ad074db
This PR was generated with Oz.