Bump Mermaid renderer dependency#12155
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR bumps the Mermaid renderer dependency, stops forcing the light theme at the Warp call site so diagram-level frontmatter can be applied, and adds a regression test for configured SVG fill and font output.
Concerns
- This changes user-visible Mermaid rendering behavior, but the PR description explicitly does not include screenshots or a screen recording. The repository review guidance requires visual evidence for user-facing changes, even when there is focused test coverage.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| let source = fetch_source.clone(); | ||
| Box::pin(async move { | ||
| mermaid_to_svg::render_mermaid_to_svg(&source, Some(&MermaidTheme::light())) | ||
| mermaid_to_svg::render_mermaid_to_svg(&source, None) |
There was a problem hiding this comment.
Description
Bumps
mermaid_to_svgto the latest mergedwarpdotdev/mermaid-to-svgmain commit, which includes Mermaid frontmatter/config handling and the rasterizable SVG background change from PR 17.Also updates Warp's Mermaid asset renderer to let
mermaid-to-svgapply diagram-level frontmatter formatting directives instead of forcing the light theme at the call site. This preserves the default light rendering behavior while allowing supported per-diagram config like theme variables and font settings to take effect.Adds a regression test that renders a Mermaid diagram containing frontmatter formatting directives and verifies the generated SVG includes the configured fill and font family.
Agent conversation: https://staging.warp.dev/conversation/43adc087-dbf8-47b2-a476-6981e71ad10c
Linked Issue
ready-to-specorready-to-implement.Related:
Testing
./script/run./script/formatcargo clippy --workspace --all-targets --all-features --tests -- -D warningscargo nextest run --no-fail-fast --workspace mermaid_asset_source_renders_frontmatter_formatting_directivesScreenshots / Videos
Not included; this PR is covered by a focused SVG-rendering regression test rather than screenshot comparison.
Agent Mode
CHANGELOG-IMPROVEMENT: Mermaid diagrams now tolerate and apply supported frontmatter formatting directives when rendered in Warp.
Co-Authored-By: Oz oz-agent@warp.dev