Remove OrchestrationViewerStreamer feature flag#12164
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR removes FeatureFlag::OrchestrationViewerStreamer from DOGFOOD_FLAGS, so dogfood builds fall back from the SSE-driven orchestration shared-session viewer path to the legacy polling path by default.
Concerns
- The change is user-facing/behavioral for dogfood builds, but the PR description does not include manual testing notes, screenshots, or a screen recording demonstrating shared-session orchestration viewer behavior still works end to end with the flag disabled.
Verdict
Found: 0 critical, 0 important, 1 suggestion
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| FeatureFlag::RemoteCodebaseIndexing, | ||
| FeatureFlag::GroupedTabs, | ||
| FeatureFlag::AsyncFind, | ||
| FeatureFlag::OrchestrationViewerStreamer, |
There was a problem hiding this comment.
💡 [SUGGESTION] This disables the streamer-backed orchestration viewer path for dogfood builds; for this user-facing behavioral change, please include screenshots or a screen recording demonstrating shared-session child updates still work end to end with the flag off.
cleanup from https://github.com/warpdotdev/warp/pull/11838/changes#r3351528571
Description
Linked Issue
ready-to-specorready-to-implement.Testing
./script/runScreenshots / Videos
Agent Mode