Skip to content

Remove OrchestrationViewerStreamer feature flag#12164

Merged
dagmfactory merged 1 commit into
masterfrom
dagm/allow-gpt-models-1M-context-cleanup
Jun 3, 2026
Merged

Remove OrchestrationViewerStreamer feature flag#12164
dagmfactory merged 1 commit into
masterfrom
dagm/allow-gpt-models-1M-context-cleanup

Conversation

@dagmfactory
Copy link
Copy Markdown
Contributor

@dagmfactory dagmfactory commented Jun 3, 2026

cleanup from https://github.com/warpdotdev/warp/pull/11838/changes#r3351528571

Description

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label Jun 3, 2026
@dagmfactory dagmfactory marked this pull request as ready for review June 3, 2026 20:12
@dagmfactory dagmfactory requested a review from danielpeng2 June 3, 2026 20:12
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Jun 3, 2026

@dagmfactory

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR removes FeatureFlag::OrchestrationViewerStreamer from DOGFOOD_FLAGS, so dogfood builds fall back from the SSE-driven orchestration shared-session viewer path to the legacy polling path by default.

Concerns

  • The change is user-facing/behavioral for dogfood builds, but the PR description does not include manual testing notes, screenshots, or a screen recording demonstrating shared-session orchestration viewer behavior still works end to end with the flag disabled.

Verdict

Found: 0 critical, 0 important, 1 suggestion

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

FeatureFlag::RemoteCodebaseIndexing,
FeatureFlag::GroupedTabs,
FeatureFlag::AsyncFind,
FeatureFlag::OrchestrationViewerStreamer,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 [SUGGESTION] This disables the streamer-backed orchestration viewer path for dogfood builds; for this user-facing behavioral change, please include screenshots or a screen recording demonstrating shared-session child updates still work end to end with the flag off.

@dagmfactory dagmfactory merged commit 9727a08 into master Jun 3, 2026
48 checks passed
@dagmfactory dagmfactory deleted the dagm/allow-gpt-models-1M-context-cleanup branch June 3, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants