Add setting to hide the title bar search bar in vertical tab layout#12249
Conversation
Adds the appearance.vertical_tabs.hide_title_bar_search_bar setting (boolean, default off). When the vertical tab layout is active and the setting is enabled, the title-bar search bar is replaced by an empty flexible slot so the right-side controls stay right-aligned. Horizontal layouts are unaffected, and search remains reachable via the command palette and keyboard shortcuts. The settings toggle appears under Settings > Appearance > Tabs, only when the vertical tabs feature is enabled. Fixes warpdotdev#12218
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a synced Appearance setting for hiding the title-bar search bar when vertical tabs are active, wires it into the vertical-tabs title bar render path, refreshes the workspace on setting changes, and adds settings path/default tests. The PR description includes visual evidence for the user-facing behavior.
Concerns
- No blocking concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
bholmesdev
left a comment
There was a problem hiding this comment.
Hadn't noticed you opened a PR when I made my own. This looks good! Thanks
Description
Adds a user setting that hides the search bar in the title bar when the vertical tab layout is active, per #12218. Users on vertical tabs who prefer minimal top chrome can remove the search bar from the title bar; search remains reachable through the command palette and keyboard shortcuts.
The new setting is
appearance.vertical_tabs.hide_title_bar_search_bar(boolean, default off). When vertical tabs are active and the setting is on, the title-bar search bar is replaced by an empty flexible slot, so the right-side controls stay right-aligned. The change lives entirely inside the vertical-tabs render path, so horizontal tab layouts are unaffected.The toggle appears under Settings → Appearance → Tabs ("Hide search bar in vertical tab layout"), shown only when the vertical tabs feature is enabled — mirroring the existing vertical-tabs toggles.
Linked Issue
ready-to-specorready-to-implement.Fixes #12218
Testing
cargo fmt -- --checkcargo check -p warpcargo clippy -p warp --all-targets --tests -- -D warningscargo nextest run -p warp hide_title_bar_search_bar— 2/2 passing (new: defaults-to-false + toml-path)./script/runScreenshots / Videos
12249_before_after.mp4
Toggling Settings → Appearance → Tabs → “Hide search bar in vertical tab layout” while in vertical tab mode: the title-bar search bar is hidden when the setting is ON (right-side controls stay right-aligned) and restored when OFF. Horizontal tab layouts are unaffected.
Agent Mode