Skip to content

Add setting to hide the title bar search bar in vertical tab layout#12249

Merged
bholmesdev merged 1 commit into
warpdotdev:masterfrom
maxmilian:maxmilian/fix-12218-hide-search-bar-vertical-tabs
Jun 7, 2026
Merged

Add setting to hide the title bar search bar in vertical tab layout#12249
bholmesdev merged 1 commit into
warpdotdev:masterfrom
maxmilian:maxmilian/fix-12218-hide-search-bar-vertical-tabs

Conversation

@maxmilian
Copy link
Copy Markdown
Contributor

@maxmilian maxmilian commented Jun 5, 2026

Description

Adds a user setting that hides the search bar in the title bar when the vertical tab layout is active, per #12218. Users on vertical tabs who prefer minimal top chrome can remove the search bar from the title bar; search remains reachable through the command palette and keyboard shortcuts.

The new setting is appearance.vertical_tabs.hide_title_bar_search_bar (boolean, default off). When vertical tabs are active and the setting is on, the title-bar search bar is replaced by an empty flexible slot, so the right-side controls stay right-aligned. The change lives entirely inside the vertical-tabs render path, so horizontal tab layouts are unaffected.

The toggle appears under Settings → Appearance → Tabs ("Hide search bar in vertical tab layout"), shown only when the vertical tabs feature is enabled — mirroring the existing vertical-tabs toggles.

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below.

Fixes #12218

Testing

  • cargo fmt -- --check
  • cargo check -p warp
  • cargo clippy -p warp --all-targets --tests -- -D warnings
  • cargo nextest run -p warp hide_title_bar_search_bar — 2/2 passing (new: defaults-to-false + toml-path)
  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

12249_before_after.mp4

Toggling Settings → Appearance → Tabs → “Hide search bar in vertical tab layout” while in vertical tab mode: the title-bar search bar is hidden when the setting is ON (right-side controls stay right-aligned) and restored when OFF. Horizontal tab layouts are unaffected.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Adds the appearance.vertical_tabs.hide_title_bar_search_bar setting
(boolean, default off). When the vertical tab layout is active and the
setting is enabled, the title-bar search bar is replaced by an empty
flexible slot so the right-side controls stay right-aligned. Horizontal
layouts are unaffected, and search remains reachable via the command
palette and keyboard shortcuts.

The settings toggle appears under Settings > Appearance > Tabs, only when
the vertical tabs feature is enabled.

Fixes warpdotdev#12218
@cla-bot cla-bot Bot added the cla-signed label Jun 5, 2026
@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Jun 5, 2026
@maxmilian maxmilian marked this pull request as ready for review June 5, 2026 14:48
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Jun 5, 2026

@maxmilian

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @johnturcoo.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds a synced Appearance setting for hiding the title-bar search bar when vertical tabs are active, wires it into the vertical-tabs title bar render path, refreshes the workspace on setting changes, and adds settings path/default tests. The PR description includes visual evidence for the user-facing behavior.

Concerns

  • No blocking concerns found.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested a review from johnturcoo June 5, 2026 14:53
Copy link
Copy Markdown
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadn't noticed you opened a PR when I made my own. This looks good! Thanks

@bholmesdev bholmesdev enabled auto-merge (squash) June 7, 2026 12:25
@bholmesdev bholmesdev merged commit d2391ba into warpdotdev:master Jun 7, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting to hide the top search bar in vertical tab layouts

2 participants