Remove OrchestrationPillBar and OrchestrationViewerPillBar feature flags#12255
Conversation
Both flags were in the default feature set (enabled for all builds). Remove them from the FeatureFlag enum, Cargo.toml, and all runtime is_enabled() checks. Dead code paths (the legacy child-agent status card in the status bar, the flag-guarded early return in inherit_share_for_local_child) are removed. The ChildAgentStatusCard view is also removed since it was only rendered when OrchestrationPillBar was off. Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
cephalonaut
force-pushed
the
matthew/remove-orch-pill-bar-flags
branch
from
62d324a to
fcefb6c
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR removes the always-enabled OrchestrationPillBar and OrchestrationViewerPillBar feature flags, deletes the legacy child-agent status card fallback, and simplifies the active pill-bar/shared-session viewer paths. I did not find a concrete security issue in the changed code.
Concerns
- The change affects user-visible orchestration UI surfaces and shared-session viewer behavior, but the PR description does not include screenshots or a screen recording. For this user-facing change, please include screenshots or a short recording demonstrating the orchestration pill bar and viewer behavior working end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
…without cfg gate The import was accidentally gated to non-WASM during the master merge, but the WASM-specific match arm in dispatch_start_agent_conversation uses it. Co-Authored-By: Oz <oz-agent@warp.dev>
advait-m
left a comment
advait-m
left a comment
There was a problem hiding this comment.
nice! agree good to clean-up now
2 participants
Description
Remove the
OrchestrationPillBarandOrchestrationViewerPillBarfeature flags, which were already in thedefaultfeature set and enabled for all builds.What
FeatureFlagenum and all Cargo feature declarationsis_enabled()runtime checks throughout the codebase, keeping the code paths that were active when the flags were onChildAgentStatusCardview, which was only rendered whenOrchestrationPillBarwas OFF (now dead code)inherit_share_for_local_childand simplify the condition inmaybe_add_parent_navigation_cardAlso picks up
OrchestrationV2removal andorchestration_viewer_streameraddition from master.Why
Both flags were already in the
defaultfeature set, making all theis_enabled()checks permanently true. Removing them reduces technical debt and dead code.Agent Mode
CHANGELOG-NONE
Oz conversation