Upgrade tink-rust version#12261
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates the tink-rust patches from warpdotdev/main to warpdotdev/v0.3.0-eecf54c, with the lockfile moving the Tink crates to commit 54b9ac9af93b0c08b446a7bc0582836c9403a71b and picking up the associated serde_json/zmij lockfile changes. No approved spec context was provided, and the change is not user-visible.
Concerns
- The Tink patches still use a mutable branch in
Cargo.toml; pinning the reviewed commit would make future lockfile refreshes deterministic for this crypto dependency.
Security
- Supply-chain hardening: pin the exact reviewed Tink commit with
revinstead of relying on a branch name.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| tink-core = { git = "https://github.com/warpdotdev/tink-rust", branch = "warpdotdev/v0.3.0-eecf54c" } | ||
| tink-proto = { git = "https://github.com/warpdotdev/tink-rust", branch = "warpdotdev/v0.3.0-eecf54c" } | ||
| tink-hybrid = { git = "https://github.com/warpdotdev/tink-rust", branch = "warpdotdev/v0.3.0-eecf54c" } |
There was a problem hiding this comment.
💡 [SUGGESTION] [SECURITY] These crypto dependencies still resolve from a mutable branch; pin the reviewed commit with rev so future lockfile refreshes cannot silently move Tink code.
| tink-core = { git = "https://github.com/warpdotdev/tink-rust", branch = "warpdotdev/v0.3.0-eecf54c" } | |
| tink-proto = { git = "https://github.com/warpdotdev/tink-rust", branch = "warpdotdev/v0.3.0-eecf54c" } | |
| tink-hybrid = { git = "https://github.com/warpdotdev/tink-rust", branch = "warpdotdev/v0.3.0-eecf54c" } | |
| tink-core = { git = "https://github.com/warpdotdev/tink-rust", rev = "54b9ac9af93b0c08b446a7bc0582836c9403a71b" } | |
| tink-proto = { git = "https://github.com/warpdotdev/tink-rust", rev = "54b9ac9af93b0c08b446a7bc0582836c9403a71b" } | |
| tink-hybrid = { git = "https://github.com/warpdotdev/tink-rust", rev = "54b9ac9af93b0c08b446a7bc0582836c9403a71b" } |
Description
Linked Issue
ready-to-specorready-to-implement.Testing
./script/runScreenshots / Videos
Agent Mode