defer restoration until initialization is done#12279
Conversation
| launch_mode.supports_indexing(), | ||
| ); | ||
| if matches!(launch_mode, LaunchMode::RemoteServerDaemon { .. }) { | ||
| codebase_index_config = codebase_index_config.defer_persisted_index_restore(); |
There was a problem hiding this comment.
defer for remote daemon case
| } | ||
|
|
||
| pub fn start_persisted_index_restore(&mut self, ctx: &mut ModelContext<Self>) { | ||
| if self.persisted_index_restore_started || !self.is_indexing_enabled() { |
There was a problem hiding this comment.
idenpotent, will return early
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR defers persisted codebase index restoration for remote server daemon launches until the Initialize handler has applied client-provided codebase indexing limits. It adds queue pause/start state, wires deferred startup through the remote daemon initialization path, and includes tests for immediate and deferred restore behavior.
Concerns
No blocking correctness, security, or spec-drift concerns found in the annotated diff. No approved spec context was available for this PR.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
2 participants
Description
Defer restoration of persisted indicies until initailization is done for remote daemons so we read the correct codebase indexing limit
Linked Issue
N/A
ready-to-specorready-to-implement.Testing
Previously, on startup, these would be erroring. Now they're all correctly green
./script/runScreenshots / Videos
Agent Mode