feat(telemetry): enforce enterprise policy in native clients#12285
feat(telemetry): enforce enterprise policy in native clients#12285captainsafia wants to merge 1 commit into
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds rollout-gated native enforcement for organization telemetry policy, including policy conversion from GraphQL, privacy settings propagation, queue/persistence enforcement, daemon startup handling, and CLI agent-run deferral.
Concerns
- The PR changes user-facing Privacy settings behavior for organization-managed telemetry states, but the description has no screenshot or screen recording and notes manual end-to-end validation was deferred. Warp review guidance requires visual evidence for behavioral/UI-impacting changes.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| UgcCollectionEnablementSetting::Disable => (false, false), | ||
| UgcCollectionEnablementSetting::RespectUserSetting => { | ||
| (true, privacy_settings.is_telemetry_enabled) | ||
| let (is_toggleable, is_checked) = match privacy_settings.organization_telemetry_policy() { |
There was a problem hiding this comment.
Fail closed until organization policy loads, honor force-disabled across native telemetry paths, and preserve functional Oz behavior. Co-Authored-By: Oz <oz-agent@warp.dev>
e821869 to
fb209a3
Compare
Description
CLI.Execute.Agent.Runand the Oz core loop; propagate final refresh failures.FeatureFlag::EnterpriseTelemetryPolicyis off and leaveSetupClientEventReporterand functional/control-plane APIs unchanged.Linked Issue
Rollout
FeatureFlag::EnterpriseTelemetryPolicyis enabled for dogfood only and excluded from release/default features until the pre-enforcement decision gate is complete.Testing
/workspace/warp/script/format --check/workspace/warp/script/check_no_inline_test_modulesCARGO_BUILD_JOBS=1 cargo check -p warp_graphql -p warp --libwarp_completer./script/runAgent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/6c18a6aa-377a-4c2f-987e-e69c2102bfe3
Run: https://oz.staging.warp.dev/runs/019e99c5-30bc-70f0-8dd6-8dca323d137b
Plans:
This PR was generated with Oz.