remove unneeded focus_ai_block_if_self_focused#12286
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR removes the extra focus_ai_block_if_self_focused call from the FinishedReceivingOutput path when another AI block is active, allowing the existing focus redetermination logic to distinguish user-intended AI-block focus from transient async focus changes. The PR includes visual/manual testing evidence, and no approved spec context was provided.
Concerns
- No blocking correctness, security, or spec-drift concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Description
edf8354 changed it so that we avoid resetting focus whenever any AI block is stolen. But this means we'd have instances where we want focus to be stolen back to the input editor that weren't triggering.
Here's a video of the issue
https://github.com/user-attachments/assets/d8d528cc-d117-4155-a71b-3fce14626ce7
This PR removes the unnecessary focus attempt so
redetermine_terminal_focuscan continue distinguishing intentional AI-block focus from elsewhere without preserving an async accidental steal.Linked Issue
N/A
Testing
Manually tested
./script/runScreenshots / Videos
https://www.loom.com/share/e23ae73a05dc42609abd2a888772047e
Agent Mode